Skip to content

Fix typo #23019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2021
Merged

Fix typo #23019

merged 1 commit into from
Feb 3, 2021

Conversation

Harry-Lees
Copy link
Contributor

@Harry-Lees Harry-Lees commented Oct 29, 2020 •
edited by miss-islington
Loading

Fixed possible typo in comment

Automerge-Triggered-By: GH:Mariatta

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Harry-Lees

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@pganssle pganssle removed the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 16, 2021
Mariatta
Mariatta approved these changes Jan 16, 2021
View reviewed changes
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pganssle
Copy link
Member

I think this is not a typo, or if it is this is not the right solution. There is no method or calls called datetime.timetz.

@pganssle
Copy link
Member

Oh wait, ignore that. Wrong on both counts, apparently.

@Mariatta
Copy link
Member

So, is this ready to merge, or do you want to do it @pganssle ? I added backport labels.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jan 17, 2021
@miss-islington miss-islington merged commit bfe544d into python:master Feb 3, 2021
@miss-islington
Copy link
Contributor

Thanks @Harry-Lees for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @Harry-Lees, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker bfe544d2f2c2e7a7c03a764bed3276a1e27a0f5c 3.9

@miss-islington miss-islington self-assigned this Feb 3, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 3, 2021
@Harry-Lees @miss-islington
Fix typo (pythonGH-23019)
ad84b4f 
Fixed possible typo in comment
(cherry picked from commit bfe544d)

Co-authored-by: Harry <harry.lees@gmail.com>
@bedevere-bot
Copy link

GH-24434 is a backport of this pull request to the 3.8 branch.

@Mariatta Mariatta added needs backport to 3.9 only security fixes and removed needs backport to 3.9 only security fixes labels Feb 3, 2021
@miss-islington
Copy link
Contributor

Thanks @Harry-Lees for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 3, 2021
@Harry-Lees @miss-islington
Fix typo (pythonGH-23019)
1fe4eed 
Fixed possible typo in comment
(cherry picked from commit bfe544d)

Co-authored-by: Harry <harry.lees@gmail.com>
@bedevere-bot
Copy link

GH-24435 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Feb 3, 2021
miss-islington added a commit that referenced this pull request Feb 3, 2021
@miss-islington @Harry-Lees
Fix typo (GH-23019)
20d4375 
Fixed possible typo in comment
(cherry picked from commit bfe544d)

Co-authored-by: Harry <harry.lees@gmail.com>
miss-islington added a commit that referenced this pull request Feb 3, 2021
@miss-islington @Harry-Lees
Fix typo (GH-23019)
2603d77 
Fixed possible typo in comment
(cherry picked from commit bfe544d)

Co-authored-by: Harry <harry.lees@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@Harry-Lees @adorilson
Fix typo (pythonGH-23019)
5c32cdc 
Fixed possible typo in comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

@abalkin abalkin Awaiting requested review from abalkin

@pganssle pganssle Awaiting requested review from pganssle

Assignees

@miss-islington miss-islington

Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Harry-Lees @the-knights-who-say-ni @pganssle @Mariatta @miss-islington @bedevere-bot