Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42180: fix plural in arguments and control #23015

Merged
merged 1 commit into from
Oct 29, 2020
Merged

bpo-42180: fix plural in arguments and control #23015

merged 1 commit into from
Oct 29, 2020

Conversation

rffontenelle
Copy link
Contributor

@rffontenelle rffontenelle commented Oct 28, 2020 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 28, 2020
tirkarthi
tirkarthi approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@tirkarthi tirkarthi requested a review from pablogsal October 28, 2020 16:15
@pablogsal pablogsal merged commit b76a840 into python:master Oct 29, 2020
@pablogsal
Copy link
Member

Thanks @rffontenelle for the PR!

@rffontenelle
Copy link
Contributor Author

Sorry for the delay, but can we have a backport to 3.9? (sorry if I should have asked it before)

@miss-islington
Copy link
Contributor

Thanks @rffontenelle for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@pablogsal
Copy link
Member

Sorry for the delay, but can we have a backport to 3.9? (sorry if I should have asked it before)

Given that this is a docs fix, yup

@bedevere-bot
Copy link

GH-23114 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 2, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 2, 2020
@rffontenelle @miss-islington
bpo-42180: fix plural in arguments and control (pythonGH-23015)
e333c84 
https://bugs.python.org/issue42180
(cherry picked from commit b76a840)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
@python python deleted a comment from miss-islington Nov 2, 2020
@python python deleted a comment from miss-islington Nov 2, 2020
pablogsal pushed a commit that referenced this pull request Nov 3, 2020
@miss-islington @rffontenelle
bpo-42180: fix plural in arguments and control (GH-23015) (GH-23114)
6b7a90d 
https://bugs.python.org/issue42180
(cherry picked from commit b76a840)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@rffontenelle @adorilson
bpo-42180: fix plural in arguments and control (pythonGH-23015)
dbddcc7 
https://bugs.python.org/issue42180
@rffontenelle rffontenelle deleted the patch-3 branch November 6, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

@pablogsal pablogsal

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rffontenelle @pablogsal @miss-islington @bedevere-bot @tirkarthi @the-knights-who-say-ni @isidentical