Skip to content

bpo-42090: zipfile.Path.joinpath now accepts multiple arguments #22976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 16, 2020
Merged

bpo-42090: zipfile.Path.joinpath now accepts multiple arguments #22976

merged 3 commits into from
Dec 16, 2020

Conversation

@jaraco
Copy link
Member

@jaraco jaraco commented Oct 25, 2020 •
edited by miss-islington
Loading

https://bugs.python.org/issue42090

Automerge-Triggered-By: GH:jaraco

@jaraco jaraco requested a review from taleinat October 25, 2020 18:59
@jaraco
Copy link
Member Author

jaraco commented Oct 25, 2020

Hi Tal. Good to meet you this week. Github suggests you might be a good reviewer for this change. Please take a look, or let me know if you'd rather not receive requests like these.

@taleinat
Copy link
Contributor

taleinat commented Oct 25, 2020

Hey @jaraco! I'm happy to receive such requests :)

This seems like a straightforward improvement. I think this should be mentioned in the docs, though. Strange that this method is undocumented; is that intentional? Seems like a good opportunity to fix this?

@jaraco
Copy link
Member Author

jaraco commented Oct 25, 2020

This seems like a straightforward improvement. I think this should be mentioned in the docs, though. Strange that this method is undocumented; is that intentional? Seems like a good opportunity to fix this?

I had the same instinct, but didn't feel motivated enough to include it in this change. I'll add it.

@github-actions
Copy link

github-actions bot commented Dec 16, 2020

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@jaraco
Copy link
Member Author

jaraco commented Dec 16, 2020

Hi Tal. The latest commit includes docs. Please have a new look.

Mariatta
Mariatta approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my perspective. Thanks for updating the documentation.

@miss-islington miss-islington merged commit 928dbfc into python:master Dec 16, 2020
@jaraco jaraco deleted the feature/zipfile-path-joinpath-other branch December 17, 2020 01:38
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@jaraco @adorilson
bpo-42090: zipfile.Path.joinpath now accepts multiple arguments (pyth…
c4af318 
…onGH-22976)

Automerge-Triggered-By: GH:jaraco
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

@taleinat taleinat Awaiting requested review from taleinat

Assignees

No one assigned

Labels

stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jaraco @taleinat @Mariatta @the-knights-who-say-ni @bedevere-bot @miss-islington