Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33987: ttk frame inside config dialog toplevel #22943

Merged
merged 1 commit into from
Oct 24, 2020
Merged

bpo-33987: ttk frame inside config dialog toplevel #22943

merged 1 commit into from
Oct 24, 2020

Conversation

roseman
Copy link
Contributor

@roseman roseman commented Oct 24, 2020 •
edited by bedevere-bot
Loading

@roseman roseman requested a review from terryjreedy as a code owner October 24, 2020 16:09
terryjreedy
terryjreedy approved these changes Oct 24, 2020
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No difference on Windows, but now that I look, I can see the thin white border on macOS. All ttk widgets should be inside a ttk Frame. Thank you for catching something I missed.

@terryjreedy terryjreedy merged commit c579ad1 into python:master Oct 24, 2020
@miss-islington
Copy link
Contributor

Thanks @roseman for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-22951 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 24, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2020
@roseman @miss-islington
bpo-33987: Use master ttk Frame for IDLE config dialog (pythonGH-22943)
5b8ee4f 
(cherry picked from commit c579ad1)

Co-authored-by: Mark Roseman <mark@markroseman.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2020
@roseman @miss-islington
bpo-33987: Use master ttk Frame for IDLE config dialog (pythonGH-22943)
4ee3a7a 
(cherry picked from commit c579ad1)

Co-authored-by: Mark Roseman <mark@markroseman.com>
@bedevere-bot
Copy link

GH-22952 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 25, 2020
@miss-islington @roseman
bpo-33987: Use master ttk Frame for IDLE config dialog (GH-22943)
253c8eb 
(cherry picked from commit c579ad1)

Co-authored-by: Mark Roseman <mark@markroseman.com>
@python python deleted a comment from bedevere-bot Oct 25, 2020
@terryjreedy
Copy link
Member

terryjreedy commented Oct 25, 2020 •
edited
Loading

Two aarch64 buildbots (Redhat?, Fedora Stable 3.x ) had unrelated failures.
(https://buildbot.python.org/all/#builders/125/builds/193

test_zipimport

Failed subtests:

testGetCompiledSource - test.test_zipimport.CompressedZipImportTestCase
testBoth - test.test_zipimport.CompressedZipImportTestCase
testGetCompiledSource - test.test_zipimport.UncompressedZipImportTestCase
testBoth - test.test_zipimport.UncompressedZipImportTestCase

@terryjreedy terryjreedy added needs backport to 3.9 only security fixes and removed needs backport to 3.9 only security fixes labels Oct 25, 2020
@python python deleted a comment from miss-islington Oct 25, 2020
@python python deleted a comment from bedevere-bot Oct 25, 2020
miss-islington added a commit that referenced this pull request Oct 25, 2020
@miss-islington @roseman
bpo-33987: Use master ttk Frame for IDLE config dialog (GH-22943)
2d49389 
(cherry picked from commit c579ad1)

Co-authored-by: Mark Roseman <mark@markroseman.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@roseman @adorilson
bpo-33987: Use master ttk Frame for IDLE config dialog (pythonGH-22943)
1cc8ec1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

@E-Paine E-Paine E-Paine approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@roseman @miss-islington @bedevere-bot @terryjreedy @E-Paine @the-knights-who-say-ni