Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38980: Only apply -fno-semantic-interposition if available #22892

Merged
merged 1 commit into from
Oct 22, 2020
Merged

bpo-38980: Only apply -fno-semantic-interposition if available #22892

merged 1 commit into from
Oct 22, 2020

Conversation

encukou
Copy link
Member

@encukou encukou commented Oct 22, 2020 •
edited by miss-islington
Loading

https://bugs.python.org/issue38980

Automerge-Triggered-By: GH:encukou

@encukou encukou requested a review from pablogsal October 22, 2020 14:26
@encukou encukou added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Oct 22, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 4300591 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 22, 2020
@pablogsal
Copy link
Member

Seems that the failing buildbot is now working:

https://buildbot.python.org/all/#/builders/192/builds/16

pablogsal
pablogsal approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @encukou

@encukou
Copy link
Member Author

encukou commented Oct 22, 2020

There are still failing buildbots, but I don't see new issues.

@encukou encukou merged commit c6d7e82 into python:master Oct 22, 2020
@encukou encukou deleted the check-semantic-interposition branch October 22, 2020 16:11
@encukou
Copy link
Member Author

encukou commented Oct 22, 2020

Thanks for the reviews!

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@encukou @adorilson
bpo-38980: Only apply -fno-semantic-interposition if available (pytho…
3a73611 
…nGH-22892)
@erlend-aasland erlend-aasland mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@encukou @bedevere-bot @pablogsal @gpshead @the-knights-who-say-ni