bpo-30709: bad getter from Descriptor#Properties example #2288

anqurvanillapy · 2017-06-20T11:03:31Z

The purpose of obj in the example is implicit
As an argument the obj will cause errors when using Cell('b10').value because it expects more arguments, but 1 given

Based on suggestion from Fumihiro Bessho.

Based on patch by Patrila.

Patch by Dhushyanth Ramasamy.

WeakValueDictionary when collecting from another thread.

…gative integers.

….textpad.Textbox. Based on patch by Tycho Andersen.

…ject and modes "w" now are relative to the start of the file.

…eful (python#29057)

…tch by Masayuki Yamamoto

…tic seeds for random.

…ation

…ode. Patch by jan matejek and Xiang Zhang.

In urllib, suffixes in no_proxy environment variable with leading dots could match related hostnames again (e.g. .b.c matches a.b.c). Patch by Milan Oberkirch.

Issue python#29188: Support glibc 2.24 on Linux: don't use getentropy() function but read from /dev/urandom to get random bytes, for example in os.urandom(). On Linux, getentropy() is implemented which getrandom() is blocking mode, whereas os.urandom() should not block.

)

…thonGH-2137) (cherry picked from commit dc980df)

…#2151) (cherry picked from commit d79c1d4)

PyNumber_Int() creates a new reference: need to decrement result reference counter.

Add a test to check the current MAGIC_NUMBER against the expected number for the release if the current release is at candidate or final level. On test failure, describe to the developer the procedure for changing the magic number. This ensures that pre-merge CI will automatically pick up on magic number changes in maintenance releases (and explain why those are problematic), rather than relying on all core developers to be aware of the implications of such changes.

…honGH-2159) (python#2168) * bpo-24484: Avoid race condition in multiprocessing cleanup The finalizer registry can be mutated while inspected by multiprocessing at process exit. * Use test.support.start_threads() * Add Misc/NEWS. (cherry picked from commit 1eb6c00)

…nGH-2190) Replace platform with platforms. (cherry picked from commit 4ebf03d)

…honGH-2173) (pythonGH-2196) (cherry picked from commit 184bd82)

…n#2202) * bpo-29591: Upgrade Modules/expat to libexpat 2.2 * bpo-29591: Restore Python changes on expat * bpo-29591: Remove expat config of unsupported platforms Remove the configuration (Modules/expat/*config.h) of unsupported platforms: * Amiga * MacOS Classic on PPC32 * Open Watcom * bpo-29591: Remove useless XML_HAS_SET_HASH_SALT The XML_HAS_SET_HASH_SALT define of Modules/expat/expat.h became useless since our local expat copy was upgrade to expat 2.1 (it's now expat 2.2.0). (cherry picked from commit 23ec4b5)

regrtest now warms up caches: create explicitly all internal singletons which are created on demand to prevent false positives when checking for reference leaks.

…rtest (python#2249) [2.7] bpo-30540, bpo-30523: Add --matchfile and --list-cases options to regrtest

…scape (python#2174)

- The purpose of `obj` in the example is implicit - As an argument the `obj` will cause errors when using `Cell('b10').value` because it expects more arguments, but 1 given

the-knights-who-say-ni · 2017-06-20T11:03:33Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

anqurvanillapy · 2017-06-20T11:16:16Z

Oops sorry for some mess here I'm just kinda new in this amazing community 🙏

Mariatta

Thanks for the PR. I noticed you made this against the 2.7 branch. Can you make the change against the master branch first? Once the PR on master has been merged, it can be backported to the maintenance branches.

anqurvanillapy · 2017-06-21T16:11:16Z

@Mariatta Thanks for your reply! I just updated the base branch!

Mariatta · 2017-06-22T05:08:19Z

Simply changing the base branch on GitHub won't work :(

I think you'll need to rebase against the master branch, and then do a force push.

Perhaps it will be easier for you to checkout a branch that is off the master branch, eg by doing git checkout -b <branchname> master, make your edit in that branch, commit and push.

anqurvanillapy · 2017-06-22T06:09:35Z

@Mariatta I'm pretty sorry for my misconception, and perhaps it is heavily due to my direct modification on that file via GitHub webpage, which creates a new patch-1 branch and simply breaks the normal workflow of this repo itself.

I'm closing this and will new a PR with a link to this conversation. And I will clone my forked repo (which is much outdated seemingly) and use the following commands to make my changes against master branch:

$ # New branch `foo'
$ git fetch origin # updates origin/master
$ # make my changes on `foo'
$ git rebase origin/master
$ git push origin master -f
$ # New a pull request on python/cpython

Hope it works out...

brettcannon and others added 30 commits December 22, 2016 10:03

Grammatical fixes for d95f19892fd0

00ebffe

Issue python#29038: Fix duplicate get_ca_certs() doc entry.

c4f91ba

Update documentation index sidebar for 3.6.0 release.

c049575

Issue python#29004: Document binascii.crc_hqx() implements CRC-CCITT

3698bd2

Issue #1446619: Account for negative slice direction in description

427ca62

Based on suggestion from Fumihiro Bessho.

Issue python#28815: Skip TIPC tests if /proc/modules is not readable

500794d

Based on patch by Patrila.

Issue python#29078: Add the missing import in datetime.time doc example.

58c2c6e

Patch by Dhushyanth Ramasamy.

Issue python#28998: More APIs now support longs as well as ints.

994f04d

Issue python#28427: old keys should not remove new values from

f939b3c

WeakValueDictionary when collecting from another thread.

Backed out changeset 78bf34b6a713

1451874

Fixed running MiscTests in test_xml_etree_c.

e96095b

Issue python#9770: curses.ascii predicates now work correctly with ne…

f77fe6b

…gative integers.

Issue python#13051: Fixed recursion errors in large or resized curses…

4d42af1

….textpad.Textbox. Based on patch by Tycho Andersen.

Issue python#29112: Fix a questionable wording in sequence doc.

a19fd46

Issue python#29123: Make CheckSqlTimestamp more robust

c644d53

Issue python#29094: Offsets in a ZIP file created with extern file ob…

0f4ed2c

…ject and modes "w" now are relative to the start of the file.

ring in 2017 for Python

ea02cdc

only include sys/random.h if it seems like it might have something us…

2f7d13c

…eful (python#29057)

Fixed possible reference leaks in the _json module.

f04790a

Issue python#28768: Fix implicit declaration of function _setmode. Pa…

f85dbfc

…tch by Masayuki Yamamoto

add Modules/zlib/zlib.map to .hgeol

52e5868

- Issue python#29169: Update zlib to 1.2.10.

54dc428

test_curses - substitute self.skip() with self.skipTest()

9220111

Issue python#29023: Clarify that ints and longs are always determinis…

9b7ae96

…tic seeds for random.

Issue python#29189: Fix broken indentation in FancyURLopener document…

10434d6

…ation

Issue python#29145: Fix overflow checks in string, bytearray and unic…

7bdb516

…ode. Patch by jan matejek and Xiang Zhang.

Issue python#29142: Fix suffixes in no_proxy handling in urllib.

98b1c82

In urllib, suffixes in no_proxy environment variable with leading dots could match related hostnames again (e.g. .b.c matches a.b.c). Patch by Milan Oberkirch.

Issue python#29217: Fix the wrong type description of UUID.variant.

da8ea3a

revert 030e100f048a (python#29006, python#10513)

0897a55

matrixise and others added 14 commits June 12, 2017 15:30

bpo-30615: Fix the leak reference in Modules/_elementtree.c (python#2129

41af942

)

bpo-30217: add the operators ~ and | to the index (pythonGH-1502) (py…

bbb3358

…thonGH-2137) (cherry picked from commit dc980df)

[2.7] Mention how to disable signal fd wakeup (pythonGH-2140) (python…

15a6127

…#2151) (cherry picked from commit d79c1d4)

_tkinter: Fix refleak in getint() (python#2153)

bdd3567

PyNumber_Int() creates a new reference: need to decrement result reference counter.

Fix trivial typo in Python Setup documentation (pythonGH-2185) (pytho…

311054a

…nGH-2190) Replace platform with platforms. (cherry picked from commit 4ebf03d)

bpo-30659 : Use ** for kwargs in namedtuple._replace() signature (pyt…

4b30107

…honGH-2173) (pythonGH-2196) (cherry picked from commit 184bd82)

bpo-30675: Fix refleak hunting in regrtest (python#2227)

8bb0863

regrtest now warms up caches: create explicitly all internal singletons which are created on demand to prevent false positives when checking for reference leaks.

bpo-30540, bpo-30523: Add --matchfile and --list-cases options to reg…

24c2c20

…rtest (python#2249) [2.7] bpo-30540, bpo-30523: Add --matchfile and --list-cases options to regrtest

[2.7] bpo-30657: Check & prevent integer overflow in PyString_DecodeE…

c3c9db8

…scape (python#2174)

bpo-30176: Add missing curses cell attributes constants (python#2278)

b39a748

Bad getter from Descriptor#Properties example

def2be9

- The purpose of `obj` in the example is implicit - As an argument the `obj` will cause errors when using `Cell('b10').value` because it expects more arguments, but 1 given

the-knights-who-say-ni added the CLA not signed label Jun 20, 2017

anqurvanillapy changed the title ~~Bad getter from Descriptor#Properties example~~ trivial - bad getter from Descriptor#Properties example Jun 20, 2017

anqurvanillapy changed the title ~~trivial - bad getter from Descriptor#Properties example~~ bpo30709 - bad getter from Descriptor#Properties example Jun 20, 2017

anqurvanillapy changed the title ~~bpo30709 - bad getter from Descriptor#Properties example~~ bpo-30709: bad getter from Descriptor#Properties example Jun 20, 2017

rhettinger approved these changes Jun 21, 2017

View reviewed changes

Mariatta requested changes Jun 21, 2017

View reviewed changes

anqurvanillapy changed the base branch from 2.7 to master June 21, 2017 16:09

anqurvanillapy closed this Jun 23, 2017

anqurvanillapy deleted the patch-1 branch June 23, 2017 03:39

anqurvanillapy mentioned this pull request Jun 23, 2017

bpo-30709: Fixed bad getter example from Doc/Descriptor#Properties #2339

Merged

Mariatta changed the base branch from master to 2.7 June 23, 2017 03:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-30709: bad getter from Descriptor#Properties example #2288

bpo-30709: bad getter from Descriptor#Properties example #2288

anqurvanillapy commented Jun 20, 2017

the-knights-who-say-ni commented Jun 20, 2017

anqurvanillapy commented Jun 20, 2017

Mariatta left a comment

anqurvanillapy commented Jun 21, 2017 •

edited

Loading

Mariatta commented Jun 22, 2017

anqurvanillapy commented Jun 22, 2017

bpo-30709: bad getter from Descriptor#Properties example #2288

bpo-30709: bad getter from Descriptor#Properties example #2288

Conversation

anqurvanillapy commented Jun 20, 2017

the-knights-who-say-ni commented Jun 20, 2017

anqurvanillapy commented Jun 20, 2017

Mariatta left a comment

Choose a reason for hiding this comment

anqurvanillapy commented Jun 21, 2017 • edited Loading

Mariatta commented Jun 22, 2017

anqurvanillapy commented Jun 22, 2017

anqurvanillapy commented Jun 21, 2017 •

edited

Loading