Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41746: Cast to typed seqs in CHECK macros to avoid type erasure #22864

Merged
merged 1 commit into from
Oct 21, 2020
Merged

bpo-41746: Cast to typed seqs in CHECK macros to avoid type erasure #22864

merged 1 commit into from
Oct 21, 2020

Conversation

lysnikolaou
Copy link
Member

@lysnikolaou lysnikolaou commented Oct 21, 2020 •
edited by bedevere-bot
Loading

@lysnikolaou lysnikolaou mentioned this pull request Oct 21, 2020
Closed
@pablogsal
Copy link
Member

Ahhh, the beauty of types that are not void* : I don't need to review carefully the whole thing because of any of these is wrong it wouldn't compile

@pablogsal
Copy link
Member

I think we should also type now the ones in the grammars in test_c_generator or the test will start showing a bunch of warnings

@lysnikolaou
Copy link
Member Author

lysnikolaou commented Oct 21, 2020 •
edited
Loading

There are no CHECK usages in test_peg_generator. Or do you mean something else?

@pablogsal
Copy link
Member

There are no CHECK usages in test_peg_generator. Or do you mean something else?

Hummm, I am must be confusing some stuff. Can you check if running the peg tests do raise any warnings? In case is clean, we are fine, then

@lysnikolaou
Copy link
Member Author

No warnings, so I'm merging.

@lysnikolaou lysnikolaou merged commit 2e5ca9e into python:master Oct 21, 2020
@lysnikolaou lysnikolaou deleted the bpo-41746-CHECK-fix branch October 21, 2020 19:53
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@lysnikolaou @adorilson
bpo-41746: Cast to typed seqs in CHECK macros to avoid type erasure (p…
9dc034e 
…ythonGH-22864)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lysnikolaou @pablogsal @the-knights-who-say-ni @bedevere-bot