Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38980: Add -fno-semantic-interposition when building with optimizations #22862

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Oct 21, 2020

@@ -6482,6 +6482,14 @@ if test "$Py_OPT" = 'true' ; then
DEF_MAKE_ALL_RULE="profile-opt"
REQUIRE_PGO="yes"
DEF_MAKE_RULE="build_all"
case $CC in
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no conditional activation on --enable-shared because C extensions can also benefit from this (and they inherit the build flags).

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see one ReST syntax issue, otherwise LGTM

Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@pablogsal pablogsal merged commit b451b0e into python:master Oct 21, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@pablogsal pablogsal deleted the bpo-38980 branch May 19, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants