Skip to content

bpo-42066: CookieJar cookies should not be sorted #22745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

IKermani
Copy link
Contributor

@IKermani IKermani commented Oct 18, 2020

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@IKermani

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@IKermani IKermani requested a review from rhettinger October 19, 2020 09:25
@IKermani
Copy link
Contributor Author

IKermani commented Nov 30, 2020

Hi there,
I know there are much more important PRs than this, but I would really appreciate it if a code review is conducted on this PR.
Many thanks for considering my request.
@jstasiak @rhettinger

@github-actions
Copy link

github-actions bot commented Jan 2, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 2, 2021
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your News text should start with Removed rather than Fix.
No tests found that relate to cookie order hence none needed.

@rhettinger
Copy link
Contributor

Closing and reopening to trigger the CI bots.

@rhettinger rhettinger closed this Apr 20, 2022
@rhettinger rhettinger reopened this Apr 20, 2022
@rhettinger rhettinger merged commit 615b24c into python:main Apr 21, 2022
@furkanonder
Copy link
Contributor

@rhettinger The issue seems to be solved. We can close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale PR or inactive for long period of time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants