Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41939: do not skip test_site.test_license_exists_at_url for pre-releases #22688

Merged
merged 1 commit into from
Oct 14, 2020
Merged

bpo-41939: do not skip test_site.test_license_exists_at_url for pre-releases #22688

merged 1 commit into from
Oct 14, 2020

Conversation

ned-deily
Copy link
Member

@ned-deily ned-deily commented Oct 14, 2020 •
edited by bedevere-bot
Loading

This test is skipped for pre-releases because the license file URL in Lib/site.py used to be to a release-dependent URL. But bpo-21572 changed Lib/site.py to use a license URL that is independent of the release. So there is no longer a reason to skip the test for pre-releases and, by no longer skipping, we would catch problems like the one in this issue prior to release.

https://bugs.python.org/issue41939

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Oct 14, 2020
eamanu
eamanu approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ned-deily ned-deily merged commit 6a48518 into python:master Oct 14, 2020
@miss-islington
Copy link
Contributor

Thanks @ned-deily for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@ned-deily ned-deily deleted the bpo-41939-run-always branch October 14, 2020 01:39
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 14, 2020
@ned-deily @miss-islington
bpo-41939: always enable test_site.test_license_exists_at_url (python…
deca867 
…GH-22688)

(cherry picked from commit 6a48518)

Co-authored-by: Ned Deily <nad@python.org>
@bedevere-bot
Copy link

GH-22689 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 14, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 14, 2020
@ned-deily @miss-islington
bpo-41939: always enable test_site.test_license_exists_at_url (python…
a1143f4 
…GH-22688)

(cherry picked from commit 6a48518)

Co-authored-by: Ned Deily <nad@python.org>
@bedevere-bot
Copy link

GH-22690 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 14, 2020
@miss-islington @ned-deily
bpo-41939: always enable test_site.test_license_exists_at_url (GH-22688)
8b4642d 
(cherry picked from commit 6a48518)

Co-authored-by: Ned Deily <nad@python.org>
miss-islington added a commit that referenced this pull request Oct 14, 2020
@miss-islington @ned-deily
bpo-41939: always enable test_site.test_license_exists_at_url (GH-22688)
881a13c 
(cherry picked from commit 6a48518)

Co-authored-by: Ned Deily <nad@python.org>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@ned-deily
bpo-41939: always enable test_site.test_license_exists_at_url (python…
9df0d2e 
…GH-22688)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@ned-deily @adorilson
bpo-41939: always enable test_site.test_license_exists_at_url (python…
4b34ffc 
…GH-22688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamanu eamanu eamanu approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ned-deily @miss-islington @bedevere-bot @eamanu @the-knights-who-say-ni