Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42029: Remove dynload_dl #22687

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Conversation

kadler
Copy link
Contributor

@kadler kadler commented Oct 14, 2020

All references to this dynamic loading method were removed in b9949db,
when support for this method was dropped, but the implementation code
was not dropped (seemingly in oversight).

https://bugs.python.org/issue42029

All references to this dynamic loading method were removed in b9949db,
when support for this method was dropped, but the implementation code
was not dropped (seemingly in oversight).
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe @vstinner would like take a look?

@benjaminp benjaminp merged commit 0cafcd3 into python:master Oct 14, 2020
@kadler kadler deleted the drop-dynload-dl branch October 14, 2020 14:37
@vstinner
Copy link
Member

LGTM, but maybe @vstinner would like take a look?

No, I don't want to look at this old dead code, thanks for removing it :-D

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
All references to this dynamic loading method were removed in b9949db,
when support for this method was dropped, but the implementation code
was not dropped (seemingly in oversight).
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
All references to this dynamic loading method were removed in b9949db,
when support for this method was dropped, but the implementation code
was not dropped (seemingly in oversight).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants