bpo-30693: zip+tarfile: sort directory listing #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmwiedemann
added a commit
to bmwiedemann/obs-service-tar_scm
that referenced
this pull request
Jun 18, 2017
also needs python/cpython#2263
bmwiedemann
added a commit
to bmwiedemann/obs-service-tar_scm
that referenced
this pull request
Jun 19, 2017
to generate tar files in a reproducible way. See https://reproducible-builds.org/ for why this matters. In addition to this change, to generate completely reproducible tarballs, the build system also needs python/cpython#2263
bmwiedemann
changed the title
bmwiedemann
force-pushed
the
tarfile
branch
4 times, most recently
from
51d3ad6 to
b5551df
Compare
bitdancer
reviewed
Jan 17, 2018
to generate tar files in a more reproducible way See also https://reproducible-builds.org/docs/stable-inputs/ on that topic.
to generate zip files in a more reproducible way See also https://reproducible-builds.org/docs/stable-inputs/ on that topic.
|
updated docs to include a |
|
@brettcannon since you seem to be interested in this topic, I would really like to see the 1-line fix to tarfile.py merged |
|
@vstinner: Please replace |
ned-deily
pushed a commit
to ned-deily/cpython
that referenced
this pull request
Jan 31, 2018
tarfile and zipfile now sort directory listing to generate tar and zip archives in a more reproducible way. See also https://reproducible-builds.org/docs/stable-inputs/ on that topic.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zipfile+tarfile: sort directory listing
to generate zip and tar archives in a more reproducible way
See also https://reproducible-builds.org/docs/stable-inputs/ on that topic.
I successfully tested this change on python-2.7.13
https://bugs.python.org/issue30693