bpo-42014: shutil.rmtree: call onerror with correct function #22585
Conversation
The onerror is supposed to be called with failed function, but in this case lstat is wrongly used instead of open.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
I guess this needs a bug. cc: @serhiy-storchaka |
|
I've just created https://bugs.python.org/issue42014 |
nijel
changed the title
There was a problem hiding this comment.
The fix is correct, but it needs a news blurb. Please use https://blurb-it.herokuapp.com/ to fix it, thanks!
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @hynek: please review the changes made to this pull request. |
|
Thanks @nijel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
|
GH-23228 is a backport of this pull request to the 3.9 branch. |
|
GH-23229 is a backport of this pull request to the 3.8 branch. |
|
Thank you for cleaning up my mess and sorry for the delays! |
The onerror is supposed to be called with failed function, but in this case lstat is wrongly used instead of open. Not sure if this needs bug or not... Automerge-Triggered-By: GH:hynek (cherry picked from commit e59b2de) Co-authored-by: Michal Čihař <michal@cihar.com>
The onerror is supposed to be called with failed function, but in this case lstat is wrongly used instead of open. Not sure if this needs bug or not... Automerge-Triggered-By: GH:hynek (cherry picked from commit e59b2de) Co-authored-by: Michal Čihař <michal@cihar.com>
…H-22585) The onerror is supposed to be called with failed function, but in this case lstat is wrongly used instead of open. Not sure if this needs bug or not... Automerge-Triggered-By: GH:hynek
The onerror is supposed to be called with failed function, but in this case lstat is wrongly used instead of open.
Not sure if this needs bug or not...
https://bugs.python.org/issue42014
Automerge-Triggered-By: GH:hynek