Skip to content

bpo-25655: Improve Win DLL loading failures doc #22372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 22, 2020

Conversation

pombredanne
Copy link
Contributor

@pombredanne pombredanne commented Sep 23, 2020

Add documentation to help diagnose CDLL dependent DLL loading errors
on Windows for OSError with message:
"[WinError 126] The specified module could not be found"
This error is otherwise difficult to diagnose.

Signed-off-by: Philippe Ombredanne pombredanne@nexb.com

https://bugs.python.org/issue25655

https://bugs.python.org/issue25655

Add documentation to help diagnose CDLL dependent DLL loading errors
on windows for OSError with message:
"[WinError 126] The specified module could not be found"
This error is otherwise difficult to diagnose.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Copy link
Contributor Author

I do not think this minor doc update is news-worthy, so a core dev should add a skip news label to this PR.

Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit comment

Exception references are made with exc and not class

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@pombredanne
Copy link
Contributor Author

@corona10 I applied your suggested fix. Thank you!

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reported-by: Steve Dower <steve.dower@microsoft.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
@zooba zooba merged commit b6f2fc9 into python:master Oct 22, 2020
@miss-islington
Copy link
Contributor

Thanks @pombredanne for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @pombredanne for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2020
Add documentation to help diagnose CDLL dependent DLL loading errors
on windows for OSError with message:
"[WinError 126] The specified module could not be found"
This error is otherwise difficult to diagnose.
(cherry picked from commit b6f2fc9)

Co-authored-by: Philippe Ombredanne <pombredanne@gmail.com>
@bedevere-bot
Copy link

GH-22894 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 22, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2020
Add documentation to help diagnose CDLL dependent DLL loading errors
on windows for OSError with message:
"[WinError 126] The specified module could not be found"
This error is otherwise difficult to diagnose.
(cherry picked from commit b6f2fc9)

Co-authored-by: Philippe Ombredanne <pombredanne@gmail.com>
@bedevere-bot
Copy link

GH-22895 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 22, 2020
Add documentation to help diagnose CDLL dependent DLL loading errors
on windows for OSError with message:
"[WinError 126] The specified module could not be found"
This error is otherwise difficult to diagnose.
(cherry picked from commit b6f2fc9)

Co-authored-by: Philippe Ombredanne <pombredanne@gmail.com>
miss-islington added a commit that referenced this pull request Oct 22, 2020
Add documentation to help diagnose CDLL dependent DLL loading errors
on windows for OSError with message:
"[WinError 126] The specified module could not be found"
This error is otherwise difficult to diagnose.
(cherry picked from commit b6f2fc9)

Co-authored-by: Philippe Ombredanne <pombredanne@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Add documentation to help diagnose CDLL dependent DLL loading errors
on windows for OSError with message:
"[WinError 126] The specified module could not be found"
This error is otherwise difficult to diagnose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants