bpo-31870: Add a timeout parameter to ssl.get_server_certificate()

[ZackerySpytz]

https://bugs.python.org/issue31870

Automerge-Triggered-By: GH:tiran

[tiran]

There is a merge conflict in what's new.

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[tiran]

@ZackerySpytz This PR is also conflicting. Please resolve the conflict and then instruct Bedevere to ping me again.

[ZackerySpytz]

I have made the requested changes; please review again.

[bedevere-bot]

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

[tiran]

Thanks for your patience!

[bedevere-bot]

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows8.1 Non-Debug 3.x has failed when building commit b2fac1a.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/405/builds/14) and take a look at the build logs.
4. Check if the failure is related to this commit (b2fac1a) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/405/builds/14

Failed tests:

• test_ssl

Failed subtests:

• test_get_server_certificate_timeout - test.test_ssl.SimpleBackgroundTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

395 tests OK.

10 slowest tests:

• test_multiprocessing_spawn: 2 min 8 sec
• test_concurrent_futures: 2 min 7 sec
• test_largefile: 1 min 37 sec
• test_peg_generator: 1 min 37 sec
• test_regrtest: 1 min 17 sec
• test_io: 1 min 14 sec
• test_asyncio: 1 min
• test_mmap: 53.3 sec
• test_tokenize: 49.7 sec
• test_unparse: 44.3 sec

1 test failed:
test_ssl

30 tests skipped:
test_curses test_dbm_gnu test_dbm_ndbm test_devpoll test_epoll
test_fcntl test_fork1 test_gdb test_grp test_ioctl test_kqueue
test_multiprocessing_fork test_multiprocessing_forkserver test_nis
test_openpty test_ossaudiodev test_pipes test_poll test_posix
test_pty test_pwd test_readline test_resource test_spwd
test_syslog test_threadsignals test_wait3 test_wait4
test_xxtestfuzz test_zipfile64

1 re-run test:
test_ssl

Total duration: 8 min 57 sec

Click to see traceback logs

Traceback (most recent call last):
   File "D:\buildarea\3.x.ware-win81-release.nondebug\build\lib\test\test_ssl.py", line 2343, in wrap_conn
    self.sslconn = self.server.context.wrap_socket(
   File "D:\buildarea\3.x.ware-win81-release.nondebug\build\lib\ssl.py", line 518, in wrap_socket
    return self.sslsocket_class._create(
   File "D:\buildarea\3.x.ware-win81-release.nondebug\build\lib\ssl.py", line 1070, in _create
    self.do_handshake()
   File "D:\buildarea\3.x.ware-win81-release.nondebug\build\lib\ssl.py", line 1339, in do_handshake
    self._sslobj.do_handshake()
 ConnectionAbortedError: [WinError 10053] An established connection was aborted by the software in your host machine


Traceback (most recent call last):
  File "D:\buildarea\3.x.ware-win81-release.nondebug\build\lib\test\test_ssl.py", line 2141, in test_get_server_certificate_timeout
    ssl.get_server_certificate(self.server_addr, ca_certs=SIGNING_CA,
AssertionError: TimeoutError not raised

[bedevere-bot]

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.x has failed when building commit b2fac1a.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/146/builds/32) and take a look at the build logs.
4. Check if the failure is related to this commit (b2fac1a) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/146/builds/32

Failed tests:

• test_ssl

Failed subtests:

• test_get_server_certificate_timeout - test.test_ssl.SimpleBackgroundTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

394 tests OK.

10 slowest tests:

• test_io: 5 min 20 sec
• test_mmap: 4 min 37 sec
• test_largefile: 4 min 35 sec
• test_unparse: 3 min 8 sec
• test_tokenize: 1 min 58 sec
• test_concurrent_futures: 1 min 55 sec
• test_multiprocessing_spawn: 1 min 54 sec
• test_unicodedata: 1 min 47 sec
• test_capi: 1 min 41 sec
• test_lib2to3: 1 min 30 sec

1 test failed:
test_ssl

31 tests skipped:
test_curses test_dbm_gnu test_dbm_ndbm test_devpoll test_epoll
test_fcntl test_fork1 test_gdb test_grp test_ioctl test_kqueue
test_multiprocessing_fork test_multiprocessing_forkserver test_nis
test_openpty test_ossaudiodev test_pipes test_poll test_posix
test_pty test_pwd test_readline test_resource test_spwd
test_syslog test_threadsignals test_wait3 test_wait4
test_xxlimited test_xxtestfuzz test_zipfile64

1 re-run test:
test_ssl

Total duration: 15 min 21 sec

Click to see traceback logs

Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_ssl.py", line 2141, in test_get_server_certificate_timeout
    ssl.get_server_certificate(self.server_addr, ca_certs=SIGNING_CA,
AssertionError: TimeoutError not raised

[tiran]

@ZackerySpytz Windows doesn't like your tests. I have created #25570 to address the test issue.