bpo-41780: Fix __dir__ of types.GenericAlias #22262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Sep 15, 2020
gvanrossum
reviewed
Sep 15, 2020
Co-authored-by: Guido van Rossum <guido@python.org>
|
|
|
This presumably won't make it into 3.9.0 (IIUC rc2 is being cut as we speak and final is in three weeks; this just isn't important enough), but it should be fixed in 3.9.1. |
|
@isidentical: Status check is done, and it's a failure ❌ . |
|
@isidentical: Status check is done, and it's a success ✅ . |
|
Thanks @isidentical for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 15, 2020
Automerge-Triggered-By: @gvanrossum (cherry picked from commit 2e87774) Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
|
GH-22264 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 15, 2020
Automerge-Triggered-By: @gvanrossum (cherry picked from commit 2e87774) Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
Automerge-Triggered-By: @gvanrossum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41780
Automerge-Triggered-By: @gvanrossum