Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40077: Convert _operator to use PyType_FromSpec #21954

Merged
merged 1 commit into from
Aug 26, 2020
Merged

bpo-40077: Convert _operator to use PyType_FromSpec #21954

merged 1 commit into from
Aug 26, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Aug 25, 2020 •
edited by bedevere-bot
Loading

@corona10 corona10 requested a review from vstinner August 25, 2020 14:02
@corona10
Copy link
Member Author

@shihai1991 Can you please take a look also?

shihai1991
shihai1991 approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@shihai1991 shihai1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@corona10 corona10 changed the title bpo-40077: Convert _operaator to use PyType_FromSpec bpo-40077: Convert _operator to use PyType_FromSpec Aug 26, 2020
vstinner
vstinner approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done :-) It's easy to forget small things in such refactoring.

@corona10 corona10 merged commit 31967fd into python:master Aug 26, 2020
@corona10 corona10 deleted the bpo-40077-operator branch August 26, 2020 17:22
@vstinner
Copy link
Member

Thanks @corona10.

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@corona10
bpo-40077: Convert _operator to use PyType_FromSpec (pythonGH-21954)
20bba8b
@corona10 corona10 mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@shihai1991 shihai1991 shihai1991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corona10 @vstinner @shihai1991 @the-knights-who-say-ni @bedevere-bot