bpo-40782: Change asyncio.AbstractEventLoop.run_in_executor to be a method not a coroutine #21852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asyncio.AbstractEventLoop.run_in_executor should be a method that returns an asyncio Future, not an async method. This matches the concrete implementations, and the documentation better.
This comment has been minimized.
This comment has been minimized.
gvanrossum
approved these changes
Aug 14, 2020
|
Thanks, be sure to check yourself per instructions of the CLA bot in a few business days. |
|
@gvanrossum already done. |
gvanrossum
added
needs backport to 3.8
needs backport to 3.9
|
Thanks @jamesba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Thanks @jamesba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
GH-21903 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 17, 2020
…ethod not a coroutine (pythonGH-21852) asyncio.AbstractEventLoop.run_in_executor should be a method that returns an asyncio Future, not an async method. This matches the concrete implementations, and the documentation better. (cherry picked from commit 29f8429) Co-authored-by: James Weaver <james.barrett@bbc.co.uk>
|
GH-21904 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 17, 2020
…ethod not a coroutine (pythonGH-21852) asyncio.AbstractEventLoop.run_in_executor should be a method that returns an asyncio Future, not an async method. This matches the concrete implementations, and the documentation better. (cherry picked from commit 29f8429) Co-authored-by: James Weaver <james.barrett@bbc.co.uk>
miss-islington
added a commit
that referenced
this pull request
Aug 17, 2020
…ethod not a coroutine (GH-21852) asyncio.AbstractEventLoop.run_in_executor should be a method that returns an asyncio Future, not an async method. This matches the concrete implementations, and the documentation better. (cherry picked from commit 29f8429) Co-authored-by: James Weaver <james.barrett@bbc.co.uk>
miss-islington
added a commit
that referenced
this pull request
Aug 17, 2020
…ethod not a coroutine (GH-21852) asyncio.AbstractEventLoop.run_in_executor should be a method that returns an asyncio Future, not an async method. This matches the concrete implementations, and the documentation better. (cherry picked from commit 29f8429) Co-authored-by: James Weaver <james.barrett@bbc.co.uk>
|
|
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 20, 2020
…ethod not a coroutine (pythonGH-21852) asyncio.AbstractEventLoop.run_in_executor should be a method that returns an asyncio Future, not an async method. This matches the concrete implementations, and the documentation better.
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
…ethod not a coroutine (pythonGH-21852) asyncio.AbstractEventLoop.run_in_executor should be a method that returns an asyncio Future, not an async method. This matches the concrete implementations, and the documentation better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asyncio.AbstractEventLoop.run_in_executor should be a method that returns an asyncio Future, not an async method.
This matches the concrete implementations, and the documentation better.
https://bugs.python.org/issue40782
Automerge-Triggered-By: @gvanrossum