Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41497: Fix potential UnicodeDecodeError in dis #21757

Merged
merged 2 commits into from
Aug 8, 2020
Merged

bpo-41497: Fix potential UnicodeDecodeError in dis #21757

merged 2 commits into from
Aug 8, 2020

Conversation

zkonge
Copy link
Contributor

@zkonge zkonge commented Aug 6, 2020

@methane
Copy link
Member

methane commented Aug 7, 2020

Would you add a news entry?

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM.

Please add a NEWS entry.

@zkonge
Copy link
Contributor Author

zkonge commented Aug 7, 2020

NEWS added.

@methane methane merged commit a4084b9 into python:master Aug 8, 2020
@miss-islington
Copy link
Contributor

Thanks @zkonge for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 8, 2020
(cherry picked from commit a4084b9)

Co-authored-by: Konge <zkonge@outlook.com>
@bedevere-bot
Copy link

GH-21782 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Aug 8, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 8, 2020
(cherry picked from commit a4084b9)

Co-authored-by: Konge <zkonge@outlook.com>
@bedevere-bot
Copy link

GH-21783 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Aug 8, 2020
(cherry picked from commit a4084b9)

Co-authored-by: Konge <zkonge@outlook.com>
miss-islington added a commit that referenced this pull request Aug 8, 2020
(cherry picked from commit a4084b9)

Co-authored-by: Konge <zkonge@outlook.com>
@zkonge zkonge deleted the zkonge/fix_dis_encoding branch August 8, 2020 11:45
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants