Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41422: Visit the Unpickler's memo in Unpickler_traverse #21664

Merged
merged 5 commits into from
Nov 27, 2023
Merged

bpo-41422: Visit the Unpickler's memo in Unpickler_traverse #21664

merged 5 commits into from
Nov 27, 2023

Conversation

kale-smoothie
Copy link
Contributor

@kale-smoothie kale-smoothie commented Jul 28, 2020 •
edited by bedevere-bot
Loading 

[bpo-41422](https://bugs.python.org/issue41422): Visit the Unpickler's memo in Unpickler_traverse

https://bugs.python.org/issue41422

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@kale-smoothie

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@kale-smoothie kale-smoothie changed the title Visit the Unpickler's memo in Unpickler_traverse bpo-41422: Visit the Unpickler's memo in Unpickler_traverse Jul 28, 2020
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Jul 28, 2020 •
edited
Loading

Could you please add a news entry, using either the blurb utility or the blurb-it service?

@kumaraditya303
Copy link
Contributor

Closing and reopening to trigger CI.

@kumaraditya303 kumaraditya303 added needs backport to 3.10 only security fixes extension-modules C modules in the Modules dir needs backport to 3.11 only security fixes labels Jun 26, 2022
kumaraditya303
kumaraditya303 approved these changes Jun 26, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

serhiy-storchaka
serhiy-storchaka reviewed Jun 27, 2022
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Pickler?

@hugovk hugovk removed the needs backport to 3.10 only security fixes label Apr 7, 2023
@serhiy-storchaka serhiy-storchaka self-assigned this Nov 27, 2023
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.12 bug and security fixes label Nov 27, 2023
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) November 27, 2023 17:38
@serhiy-storchaka serhiy-storchaka merged commit 967f2a3 into python:main Nov 27, 2023
@miss-islington-app
Copy link

Thanks @kale-smoothie for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @kale-smoothie and @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 967f2a3052c2d22e31564b428a9aa8cc63dc2a9f 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 27, 2023
@kale-smoothie @serhiy-storchaka @miss-islington
bpo-41422: Visit the Pickler's and Unpickler's memo in tp_traverse (p…
8becbc5 
…ythonGH-21664)

(cherry picked from commit 967f2a3)

Co-authored-by: kale-smoothie <34165060+kale-smoothie@users.noreply.github.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 27, 2023

GH-112464 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 27, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Nov 27, 2023
@kale-smoothie @serhiy-storchaka
[3.11] bpo-41422: Visit the Pickler's and Unpickler's memo in tp_trav…
25b1926 
…erse (pythonGH-21664)

(cherry picked from commit 967f2a3)

Co-authored-by: kale-smoothie <34165060+kale-smoothie@users.noreply.github.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 27, 2023

GH-112465 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Nov 27, 2023
serhiy-storchaka added a commit that referenced this pull request Nov 27, 2023
@miss-islington @kale-smoothie @serhiy-storchaka
[3.12] bpo-41422: Visit the Pickler's and Unpickler's memo in tp_trav…
4463d2e 
…erse (GH-21664) (GH-112464)

(cherry picked from commit 967f2a3)

Co-authored-by: kale-smoothie <34165060+kale-smoothie@users.noreply.github.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Nov 27, 2023
@serhiy-storchaka @kale-smoothie
[3.11] bpo-41422: Visit the Pickler's and Unpickler's memo in tp_trav…
054d18e 
…erse (GH-21664) (GH-112465)

(cherry picked from commit 967f2a3)

Co-authored-by: kale-smoothie <34165060+kale-smoothie@users.noreply.github.com>
@kale-smoothie kale-smoothie mannequin mentioned this pull request Apr 7, 2023
Closed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@kale-smoothie @serhiy-storchaka @aisk
bpo-41422: Visit the Pickler's and Unpickler's memo in tp_traverse (p…
15c4739 
…ythonGH-21664)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@kale-smoothie @serhiy-storchaka @Glyphack
bpo-41422: Visit the Pickler's and Unpickler's memo in tp_traverse (p…
f03151c 
…ythonGH-21664)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

@serhiy-storchaka serhiy-storchaka

Labels
extension-modules C modules in the Modules dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kale-smoothie @the-knights-who-say-ni @serhiy-storchaka @kumaraditya303 @hugovk @ezio-melotti @bedevere-bot