bpo-41402: Fix email ContentManager calling .encode() on bytes

[joreiff]

If assigning binary content to an EmailMessage via set_content(), the function email.contentmanager.set_bytes_content() is called. This function fails when choosing the 7bit transfer encoding because of a call to data.decode('ascii'). Since bytes does not have a method .decode(), an exception is raised.

By changing data.decode('ascii') to data = data.encode('ascii'), we make sure that the input data really is 7bit and at the same time remove an inefficiency since set_payload() would have decoded the data anyway.

https://bugs.python.org/issue41402

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@joreiff

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

[joreiff]

Is there anything else I need to do before this PR can be merged?

[joreiff]

@bitdancer How does merging work? Do I need to do something regarding the Python 3.8 and 3.9 backports?

[miss-islington]

Thanks @joreiff for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

[bedevere-bot]

GH-27686 is a backport of this pull request to the 3.10 branch.

[bedevere-bot]

GH-27687 is a backport of this pull request to the 3.9 branch.

[joreiff]

Perfect, thank you!