Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41343: Convert methods of complex to Argument Clinic #21550

Merged
merged 3 commits into from
Jul 20, 2020
Merged

bpo-41343: Convert methods of complex to Argument Clinic #21550

merged 3 commits into from
Jul 20, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Jul 19, 2020 •
edited by bedevere-bot
Loading

@corona10 corona10 force-pushed the bpo-41343 branch 2 times, most recently from c774e24 to 39c9f2c Compare July 19, 2020 15:01
@corona10 corona10 changed the title bpo-41343: Convert methods of :class:complex to Argument Clinic bpo-41343: Convert methods of complex to Argument Clinic Jul 19, 2020
serhiy-storchaka
serhiy-storchaka reviewed Jul 19, 2020
View reviewed changes
Misc/NEWS.d/next/Core and Builtins/2020-07-19-23-54-52.bpo-41343.IR0Zy-.rst Outdated Show resolved Hide resolved
Objects/complexobject.c Outdated Show resolved Hide resolved
Objects/complexobject.c Outdated Show resolved Hide resolved
serhiy-storchaka
serhiy-storchaka reviewed Jul 19, 2020
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove duplicated signatures. Compare with help(int) and help(float).

@corona10
Copy link
Member Author

@serhiy-storchaka

Please remove duplicated signatures. Compare with help(int) and help(float).

Updated!

serhiy-storchaka
serhiy-storchaka approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@serhiy-storchaka serhiy-storchaka merged commit e123012 into python:master Jul 20, 2020
@corona10 corona10 deleted the bpo-41343 branch July 20, 2020 13:12
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@corona10 @arun-mani-j
bpo-41343: Convert methods of complex to Argument Clinic (pythonGH-21550
2fdca6f 
)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
@corona10 @shihai1991
bpo-41343: Convert methods of complex to Argument Clinic (pythonGH-21550
ca8d63e 
)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@corona10 @shihai1991
bpo-41343: Convert methods of complex to Argument Clinic (pythonGH-21550
c12e277 
)
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@corona10
bpo-41343: Convert methods of complex to Argument Clinic (pythonGH-21550
6a2431f 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corona10 @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot