[3.8] bpo-41247: asyncio.set_running_loop() cache running loop holder #21406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tontinton
changed the title
tontinton
force-pushed
the
fix-issue-41247-3.8
branch
from
d21ecdc to
e2aac17
Compare
tontinton
changed the title
The running loop holder cache variable was always set to NULL when calling set_running_loop. Now set_running_loop saves the newly created running loop holder in the cache variable for faster access in get_running_loop.
tontinton
force-pushed
the
fix-issue-41247-3.8
branch
from
e2aac17 to
981d410
Compare
tontinton
changed the title
|
Hm, I liked the previous version of the patch better. Why did you change it? |
_PyThreadState_GetDict() and PyThreadState_GetID() don't exist in 3.8, |
1st1
approved these changes
Jul 9, 2020
|
@1st1: Please replace |
Fair enough. Thanks for the PRs and I hope we'll see more contributions from you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The running loop holder cache variable was always set to NULL when
calling set_running_loop.
Now set_running_loop saves the newly created running loop holder in the
cache variable for faster access in get_running_loop.
https://bugs.python.org/issue41247