Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41217: Fix incorrect note in the asyncio.create_subprocess_shell() docs #21360

Merged

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Jul 6, 2020

On Windows, the default asyncio event loop is ProactorEventLoop (as
of 3.8).

https://bugs.python.org/issue41217

…) docs

On Windows, the default asyncio event loop is ProactorEventLoop (as
of 3.8).
@ZackerySpytz
Copy link
Contributor Author

This is a "skip news" PR.

@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2020
…) docs (pythonGH-21360)

On Windows, the default asyncio event loop is ProactorEventLoop (as of 3.8).
(cherry picked from commit 4dfb190)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 19, 2020
@bedevere-bot
Copy link

GH-22792 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2020
…) docs (pythonGH-21360)

On Windows, the default asyncio event loop is ProactorEventLoop (as of 3.8).
(cherry picked from commit 4dfb190)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

GH-22793 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 19, 2020
…) docs (GH-21360)

On Windows, the default asyncio event loop is ProactorEventLoop (as of 3.8).
(cherry picked from commit 4dfb190)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Oct 19, 2020
…) docs (GH-21360)

On Windows, the default asyncio event loop is ProactorEventLoop (as of 3.8).
(cherry picked from commit 4dfb190)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
…) docs (pythonGH-21360)

On Windows, the default asyncio event loop is ProactorEventLoop (as of 3.8).
@e-d-n-a
Copy link

e-d-n-a commented May 28, 2021

You guys missed a copy of the same note at a different location here:
https://docs.python.org/3/library/asyncio-eventloop.html#running-subprocesses

It's still visible in all versions of the documentation for Python >=3.8 and should be fixed as well, as I (e.g.) got confused by it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants