Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41207 In distutils.spawn, rewrite FileNotFound #21359

Merged
merged 4 commits into from
Jul 7, 2020
Merged

bpo-41207 In distutils.spawn, rewrite FileNotFound #21359

merged 4 commits into from
Jul 7, 2020

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Jul 6, 2020 •
edited by miss-islington
Loading

@jaraco jaraco requested a review from vstinner July 6, 2020 20:59
@jaraco jaraco added 🤖 automerge needs backport to 3.9 only security fixes type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir labels Jul 6, 2020
@jaraco
Copy link
Member Author

jaraco commented Jul 7, 2020

And in case you weren't aware, the code/test have been committed first to pypa/distutils where I can iterate rapidly, test against multiple Python versions, and simply merge into pypa/setuptools.

vstinner
vstinner approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix. It's good that the assertRaises(DistutilsExecError) "assumption" is now codified as an actual test ;-)

@jaraco
Copy link
Member Author

jaraco commented Jul 7, 2020

Thanks for the prompt and courteous review!

@miss-islington
Copy link
Contributor

@jaraco: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 6ae2780 into python:master Jul 7, 2020
@miss-islington
Copy link
Contributor

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2020
@jaraco @miss-islington
bpo-41207 In distutils.spawn, rewrite FileNotFound (pythonGH-21359)
e6fcc2c 
Automerge-Triggered-By: @jaraco
(cherry picked from commit 6ae2780)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 7, 2020
@bedevere-bot
Copy link

GH-21373 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jul 7, 2020
@miss-islington @jaraco
bpo-41207 In distutils.spawn, rewrite FileNotFound (GH-21359)
2c82628 
Automerge-Triggered-By: @jaraco
(cherry picked from commit 6ae2780)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@jaraco @arun-mani-j
bpo-41207 In distutils.spawn, rewrite FileNotFound (pythonGH-21359)
4e45729 
Automerge-Triggered-By: @jaraco
@jaraco jaraco deleted the bugfix/41207-rewrite-filenotfound branch March 5, 2021 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaraco @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni