Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41215: Don't use NULL by default in the PEG parser keyword list #21355

Merged
merged 2 commits into from
Jul 6, 2020
Merged

bpo-41215: Don't use NULL by default in the PEG parser keyword list #21355

merged 2 commits into from
Jul 6, 2020

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 6, 2020 •
edited by miss-islington
Loading

@pablogsal pablogsal requested a review from lysnikolaou as a code owner July 6, 2020 18:35
@pablogsal pablogsal added the needs backport to 3.9 only security fixes label Jul 6, 2020
@pablogsal @lysnikolaou
Update Misc/NEWS.d/next/Core and Builtins/2020-07-06-18-36-33.bpo-412…
6689654 
…15.vFGFIz.rst

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@pablogsal
Copy link
Member Author

@lysnikolaou Wanna land this one and the other yourself 😉 ?

@lysnikolaou
Copy link
Member

@lysnikolaou Wanna land this one and the other yourself 😉 ?

I was kinda hoping you'd say that! Let me try the automerge label this time.

@lysnikolaou
Copy link
Member

We should remove the needs backport to 3.9 label, since we don't need the automatic backport, right?

@bedevere-bot
Copy link

GH-21356 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 6, 2020
miss-islington pushed a commit that referenced this pull request Jul 6, 2020
@pablogsal
[3.9] bpo-41215: Don't use NULL by default in the PEG parser keyword …
54f115d 
…list (GH-21355) (GH-21356)

(cherry picked from commit 39e76c0)

Co-authored-by: Pablo Galindo <pablogsal@gmail.com>

Automerge-Triggered-By: @lysnikolaou
@miss-islington
Copy link
Contributor

@pablogsal: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 1ac0cbc into python:master Jul 6, 2020
@lysnikolaou
Copy link
Member

Worked like a charm.

@pablogsal
Copy link
Member Author

Worked like a charm.

Awesome 🎉

arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@pablogsal @arun-mani-j
bpo-41215: Don't use NULL by default in the PEG parser keyword list (p…
e5e12a9 
…ythonGH-21355)

Automerge-Triggered-By: @lysnikolaou
@pablogsal pablogsal deleted the bpo-41215 branch May 19, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @lysnikolaou @bedevere-bot @miss-islington @the-knights-who-say-ni