Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lysnikolaou to CODEOWNERS for the new parser #21252

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Add lysnikolaou to CODEOWNERS for the new parser #21252

merged 1 commit into from
Jul 1, 2020

Conversation

lysnikolaou
Copy link
Member

No description provided.

@lysnikolaou lysnikolaou requested a review from pablogsal July 1, 2020 07:23
@lysnikolaou
Copy link
Member Author

Thanks @pablogsal for not merging this. My first ever merge in CPython. Let's do this!

@pablogsal
Copy link
Member

Thanks @pablogsal for not merging this. My first ever merge in CPython. Let's do this!

go go go! 🚀 (Remember to change the '#' to GH- or the bots will be angry 🤖 )

@lysnikolaou lysnikolaou merged commit d0981e6 into python:master Jul 1, 2020
@lysnikolaou lysnikolaou deleted the update-codeowners branch July 1, 2020 09:47
@lysnikolaou
Copy link
Member Author

Yes! 🎉

@pablogsal
Copy link
Member

Congrats 🎉 The first of many :)

arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@lysnikolaou @arun-mani-j
Add lysnikolaou to CODEOWNERS for the new parser (pythonGH-21252)
a50d139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lysnikolaou @pablogsal @the-knights-who-say-ni @bedevere-bot