bpo-41138: Fix trace CLI for non-UTF-8 files. #21177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix also a resource warning when store counts and module info.
serhiy-storchaka
added
type-bug
methane
approved these changes
Jun 27, 2020
| @@ -0,0 +1,2 @@ | |||
| Fixed the :mod:`tarce` module CLI for Python source files with non-UTF-8 | |||
There was a problem hiding this comment.
Good catch! Thank you @srinivasreddy!
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 28, 2020
Fix also a resource warning when store counts and module info. (cherry picked from commit 04cdeb7) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-21196 is a backport of this pull request to the 3.9 branch. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
miss-islington
added a commit
that referenced
this pull request
Jun 28, 2020
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jun 28, 2020
Fix also a resource warning when store counts and module info.. (cherry picked from commit 04cdeb7) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-21200 is a backport of this pull request to the 3.8 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 28, 2020
fasih
pushed a commit
to fasih/cpython
that referenced
this pull request
Jun 29, 2020
Fix also a resource warning when store counts and module info.
arun-mani-j
pushed a commit
to arun-mani-j/cpython
that referenced
this pull request
Jul 21, 2020
Fix also a resource warning when store counts and module info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix also a resource warning when store counts and module info.
https://bugs.python.org/issue41138