bpo-40275: Use new test.support helper submodules in tests #21151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tests of distutils * test_buffer * test_compile * test_filecmp * test_fileinput * test_readline * test_smtpnet * test_structmembers * test_tools
vstinner
reviewed
Jun 25, 2020
Lib/test/test_fileinput.py
Outdated
| @@ -39,7 +41,7 @@ class BaseTests: | |||
| # temp file's name. | |||
| def writeTmp(self, content, *, mode='w'): # opening in text mode is the default | |||
| fd, name = tempfile.mkstemp() | |||
| self.addCleanup(support.unlink, name) | |||
| self.addCleanup(safe_unlink, name) | |||
There was a problem hiding this comment.
I would prefer to use os_helper.unlink here, rather than changing the function name.
There was a problem hiding this comment.
done.
I use safe_unlink in here's reason is that test_fileinput have import unlink as safe_unlink.
if I import os_helper again, the imports looks like more duplicated~
There was a problem hiding this comment.
It's common to import a module and import some symbols of the same module. "Inconsistencies" are common, especially in tests which are old :-)
There was a problem hiding this comment.
For such PR which basically updates tests to point to new submodules, I prefer to leave the tests unchanged, don't change the coding style in the same PR.
There was a problem hiding this comment.
(Also, PR which only changes coding style are usually rejected. In short, the coding style cannot be updated in Python code base :-))
There was a problem hiding this comment.
(Also, PR which only changes coding style are usually rejected. In short, the coding style cannot be updated in Python code base :-))
Got it, Thanks. I have know the pain of code churn( not easy for finding the historical record ;-) )
|
fasih
pushed a commit
to fasih/cpython
that referenced
this pull request
Jun 29, 2020
…21151) Use new test.support helper submodules in tests: * distutils tests * test_buffer * test_compile * test_filecmp * test_fileinput * test_readline * test_smtpnet * test_structmembers * test_tools
arun-mani-j
pushed a commit
to arun-mani-j/cpython
that referenced
this pull request
Jul 21, 2020
…21151) Use new test.support helper submodules in tests: * distutils tests * test_buffer * test_compile * test_filecmp * test_fileinput * test_readline * test_smtpnet * test_structmembers * test_tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use test helpers in the following test cases:
https://bugs.python.org/issue40275