-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-39960: Allow heap types in the "Carlo Verre" hack check that override "tp_setattro()" #21092
Conversation
…ride "tp_setattro()".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for one nit. I will apply that and land. Thanks!
@scoder: Status check is done, and it's a success ✅ . |
Thanks @scoder for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
…ride "tp_setattro()" (pythonGH-21092) Automerge-Triggered-By: @gvanrossum (cherry picked from commit 148f329) Co-authored-by: scoder <stefan_ml@behnel.de>
GH-21288 is a backport of this pull request to the 3.9 branch. |
Sorry, @scoder, I could not cleanly backport this to |
…ride "tp_setattro()" (GH-21092) Automerge-Triggered-By: @gvanrossum (cherry picked from commit 148f329) Co-authored-by: scoder <stefan_ml@behnel.de>
…ride "tp_setattro()" (pythonGH-21092) Backport to Py3.8.
GH-21339 is a backport of this pull request to the 3.8 branch. |
…ride "tp_setattro()" (pythonGH-21092) Automerge-Triggered-By: @gvanrossum
https://bugs.python.org/issue39960
Automerge-Triggered-By: @gvanrossum