Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39960: Allow heap types in the "Carlo Verre" hack check that override "tp_setattro()" #21092

Merged
merged 3 commits into from
Jul 3, 2020

Conversation

scoder
Copy link
Contributor

@scoder scoder commented Jun 23, 2020

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for one nit. I will apply that and land. Thanks!

@miss-islington
Copy link
Contributor

@scoder: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 148f329 into python:master Jul 3, 2020
@miss-islington
Copy link
Contributor

Thanks @scoder for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2020
…ride "tp_setattro()" (pythonGH-21092)

Automerge-Triggered-By: @gvanrossum
(cherry picked from commit 148f329)

Co-authored-by: scoder <stefan_ml@behnel.de>
@bedevere-bot
Copy link

GH-21288 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 3, 2020
@miss-islington
Copy link
Contributor

Sorry, @scoder, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 148f32913573c29250dfb3f0d079eb8847633621 3.8

@miss-islington miss-islington self-assigned this Jul 3, 2020
miss-islington added a commit that referenced this pull request Jul 3, 2020
…ride "tp_setattro()" (GH-21092)

Automerge-Triggered-By: @gvanrossum
(cherry picked from commit 148f329)

Co-authored-by: scoder <stefan_ml@behnel.de>
scoder added a commit to scoder/cpython that referenced this pull request Jul 5, 2020
@bedevere-bot
Copy link

GH-21339 is a backport of this pull request to the 3.8 branch.

scoder added a commit that referenced this pull request Jul 5, 2020
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants