Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41024: doc: Explicitly mention use of 'enum.Enum' as a valid container for '… #20964

Merged
merged 1 commit into from
Jun 20, 2020
Merged

bpo-41024: doc: Explicitly mention use of 'enum.Enum' as a valid container for '… #20964

merged 1 commit into from
Jun 20, 2020

Conversation

vincent-ferotin
Copy link
Contributor

@vincent-ferotin vincent-ferotin commented Jun 18, 2020 •
edited by miss-islington
Loading

…choices' argument of 'argparse.ArgumentParser.add_argument'.

Here's a short first proposal of doc. enhancement addressing bpo-41024.

https://bugs.python.org/issue41024

Automerge-Triggered-By: @csabella

@vincent-ferotin
doc: Explicitly mention use of 'enum.Enum' as a valid container for '…
2d6240d 
…choices' argument of 'argparse.ArgumentParser.add_argument'.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@vincent-ferotin

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jun 18, 2020
@csabella csabella requested a review from rhettinger June 19, 2020 12:02
@csabella csabella closed this Jun 20, 2020
@csabella csabella reopened this Jun 20, 2020
@miss-islington
Copy link
Contributor

@vincent-ferotin: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 344c2a7 into python:master Jun 20, 2020
@miss-islington
Copy link
Contributor

Thanks @vincent-ferotin for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @vincent-ferotin, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 344c2a75c1c13de781962a3f80552e66a4c89024 3.9

@miss-islington miss-islington self-assigned this Jun 20, 2020
fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
@vincent-ferotin @fasihahmad
bpo-41024: doc: Explicitly mention use of 'enum.Enum' as a valid cont…
11feef8 
…ainer for '… (pythonGH-20964)

…choices' argument of 'argparse.ArgumentParser.add_argument'.

Here's a short first proposal of doc. enhancement addressing [bpo-41024]().

Automerge-Triggered-By: @csabella
@rhettinger rhettinger added needs backport to 3.9 only security fixes and removed needs backport to 3.9 only security fixes labels Jul 17, 2020
@miss-islington
Copy link
Contributor

Thanks @vincent-ferotin for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2020
@vincent-ferotin @miss-islington
bpo-41024: doc: Explicitly mention use of 'enum.Enum' as a valid cont…
35bdf78 
…ainer for '… (pythonGH-20964)

…choices' argument of 'argparse.ArgumentParser.add_argument'.

Here's a short first proposal of doc. enhancement addressing [bpo-41024]().

Automerge-Triggered-By: @csabella
(cherry picked from commit 344c2a7)

Co-authored-by: Vincent Férotin <vincent.ferotin@gmail.com>
@bedevere-bot
Copy link

GH-21527 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 17, 2020
rhettinger pushed a commit that referenced this pull request Jul 17, 2020
@miss-islington
bpo-41024: doc: Explicitly mention use of 'enum.Enum' as a valid cont…
760552c 
…ainer for '… (GH-20964) (GH-21527)
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@vincent-ferotin @arun-mani-j
bpo-41024: doc: Explicitly mention use of 'enum.Enum' as a valid cont…
d7dcea9 
…ainer for '… (pythonGH-20964)

…choices' argument of 'argparse.ArgumentParser.add_argument'.

Here's a short first proposal of doc. enhancement addressing [bpo-41024]().

Automerge-Triggered-By: @csabella
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger rhettinger approved these changes

Assignees

@miss-islington miss-islington

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vincent-ferotin @the-knights-who-say-ni @miss-islington @bedevere-bot @rhettinger @csabella