Skip to content

bpo-40975: [doc] Identify AsyncExitStack coroutine methods #20870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2021
Merged

bpo-40975: [doc] Identify AsyncExitStack coroutine methods #20870

merged 1 commit into from
May 19, 2021

Conversation

naglis
Copy link
Contributor

@naglis naglis commented Jun 14, 2020 •
edited by bedevere-bot
Loading

@naglis
Identify AsyncExitStack coroutine methods
bc85fdb 
`enter_async_context()` and `aclose()` are coroutine methods.
@naglis naglis requested a review from 1st1 as a code owner June 14, 2020 12:28
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jun 14, 2020
remilapeyre
remilapeyre reviewed Jun 15, 2020
View reviewed changes
Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @naglis !

eamanu
eamanu approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

I think NEWS can be skipped

@naglis
Copy link
Contributor Author

naglis commented Apr 3, 2021

Bump :) If there is something missing from my side, please let me know.

@iritkatriel
Copy link
Member

closing and reopening to get a fresh testrun

@iritkatriel iritkatriel reopened this May 19, 2021
@iritkatriel iritkatriel changed the title bpo-40975: Identify AsyncExitStack coroutine methods bpo-40975: [doc] Identify AsyncExitStack coroutine methods May 19, 2021
@iritkatriel iritkatriel merged commit c054e8f into python:main May 19, 2021
@miss-islington
Copy link
Contributor

Thanks @naglis for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2021
@naglis @miss-islington
bpo-40975: [doc] Identify AsyncExitStack.enter_async_context()/aclose…
3a26cc8 
…() as coroutine methods (pythonGH-20870)

(cherry picked from commit c054e8f)

Co-authored-by: naglis <naglis@users.noreply.github.com>
@bedevere-bot
Copy link

GH-26254 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 19, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2021
@naglis @miss-islington
bpo-40975: [doc] Identify AsyncExitStack.enter_async_context()/aclose…
34bc4a6 
…() as coroutine methods (pythonGH-20870)

(cherry picked from commit c054e8f)

Co-authored-by: naglis <naglis@users.noreply.github.com>
@bedevere-bot
Copy link

GH-26255 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 19, 2021
iritkatriel pushed a commit that referenced this pull request May 19, 2021
@miss-islington @naglis
bpo-40975: [doc] Identify AsyncExitStack.enter_async_context()/aclose…
65dede6 
…() as coroutine methods (GH-20870) (GH-26254)

(cherry picked from commit c054e8f)

Co-authored-by: naglis <naglis@users.noreply.github.com>
iritkatriel pushed a commit that referenced this pull request May 19, 2021
@miss-islington @naglis
bpo-40975: [doc] Identify AsyncExitStack.enter_async_context()/aclose…
9a75cc6 
…() as coroutine methods (GH-20870) (GH-26255)

(cherry picked from commit c054e8f)

Co-authored-by: naglis <naglis@users.noreply.github.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@eamanu eamanu eamanu approved these changes

@remilapeyre remilapeyre remilapeyre approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@naglis @iritkatriel @miss-islington @bedevere-bot @eamanu @remilapeyre @the-knights-who-say-ni