bpo-40937: Remove deprecated universal mode #20775
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrjball
reviewed
Jun 11, 2020
| @@ -87,10 +87,6 @@ def open(file, mode="r", buffering=-1, encoding=None, errors=None, | |||
| returned as strings, the bytes having been first decoded using a | |||
| platform-dependent encoding or using the specified encoding if given. | |||
|
|
|||
| 'U' mode is deprecated and will raise an exception in future versions | |||
There was a problem hiding this comment.
It wont let me add a comment to the line as it is too far away from the changes, but shouldn't line 74 also be removed here?
|
Also, should the following line in gzip also be updated? if mode and ('t' in mode or 'U' in mode): |
Yes thanks! |
|
This has been removed in #81511 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40937