Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40937: Do not expose abstract collection classes in the collections module #20774

Closed
wants to merge 4 commits into from

Conversation

remilapeyre
Copy link
Contributor

@remilapeyre remilapeyre commented Jun 10, 2020

Original patch in ef092fe by Serhiy Storchaka

https://bugs.python.org/issue40937

@remilapeyre remilapeyre changed the title Do not expose abstract collection classes in the collections module bpo-40937: Do not expose abstract collection classes in the collections module Jun 10, 2020
@rhettinger
Copy link
Contributor

LGTM.

@rhettinger
Copy link
Contributor

Have Serhiy take a look this. He's up to date on how long this has been deferred and where the essential downstream packages have been updated yet.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a What's New entry.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@remilapeyre
Copy link
Contributor Author

Thanks, I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

@tirkarthi
Copy link
Member

FWIW, I created 100 issues across 3500 top PyPI packages about this. There were also several reports from Fedora about this when they updated to Python 3.9. https://github.com/search?q=is%3Aissue+author%3Atirkarthi+archived%3Afalse+collections

@serhiy-storchaka
Copy link
Member

See also #23754.

@rhettinger, merge please one of these PRs.

@rhettinger
Copy link
Contributor

That isn't up to me. Try @pablogsal

@serhiy-storchaka serhiy-storchaka removed their assignment Jan 2, 2021
@hugovk
Copy link
Member

hugovk commented Jan 13, 2021

This removal has been merged via #23754.

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants