Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usesless function from csv module #20762

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Remove usesless function from csv module #20762

merged 1 commit into from
Jun 9, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Jun 9, 2020

No description provided.

@corona10 corona10 requested a review from vstinner June 9, 2020 13:57
@corona10
Copy link
Member Author

corona10 commented Jun 9, 2020

@vstinner
While I am reading the csv module code, I found that get_string does nothing except increasing ref count.

vstinner
vstinner approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@corona10 corona10 merged commit 0383be4 into python:master Jun 9, 2020
@corona10 corona10 deleted the unused-csv branch June 9, 2020 15:33
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@corona10 @arun-mani-j
Remove usesless function from csv module (pythonGH-20762)
a63a3e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot