-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
gh-73180: Chain exceptions rather than dropping the old exception. #2072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @1st1, @loewis and @benjaminp to be potential reviewers. |
162f054
to
8c5cb16
Compare
Can you please rebase your change @serhiy-storchaka ? |
For |
8c5cb16
to
d69a996
Compare
This PR is stale because it has been open for 30 days with no activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran test suite and got:
401 tests OK.
Looks good.
This PR is stale because it has been open for 30 days with no activity. |
The feature seems to be implemented so the PR probably should be closed. try:
raise Exception('first exception')
except:
raise Exception('second exception')
|
The PR title is misleading. The PR is to keep the previously overridden exception in a bunch of C functions: _ctypes_extend_error(), call_exc_trace(), call_trace_protected(). |
This PR is stale because it has been open for 30 days with no activity. |
Uh oh!
There was an error while loading. Please reload this page.