Skip to content

bpo-40439: Update broken link in lexical analysis docs #20184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2020
Merged

bpo-40439: Update broken link in lexical analysis docs #20184

merged 1 commit into from
May 23, 2020

Conversation

Akarys42
Copy link
Contributor

@Akarys42 Akarys42 commented May 18, 2020 •
edited by miss-islington
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Akarys42

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 18, 2020
@Akarys42 Akarys42 changed the title BPO-40439: Update broken link in lexical analysis docs bpo-40439: Update broken link in lexical analysis docs May 18, 2020
remilapeyre
remilapeyre approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Akarys42, thanks for opening a new PR for this change!

While it is not always required for small documentation updates, the CLA will be needed if you want to contribute bigger changes in the future so it you should sign it if you plan to contribute again later.

@Akarys42
Copy link
Contributor Author

Hello! I've signed the CLA just before opening the PR, 14h ago 😁

csabella
csabella approved these changes May 23, 2020
View reviewed changes
Copy link
Contributor

@csabella csabella left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you for the contribution! 🎉

@miss-islington miss-islington merged commit af23f0d into python:master May 23, 2020
@miss-islington
Copy link
Contributor

Thanks @Akarys42 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2020
@Akarys42 @miss-islington
bpo-40439: Update broken link in lexical analysis docs (pythonGH-20184)
cef01bc 
Automerge-Triggered-By: @csabella
(cherry picked from commit af23f0d)

Co-authored-by: Matteo Bertucci <matteobertucci2004@gmail.com>
@bedevere-bot
Copy link

GH-20326 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 23, 2020
@bedevere-bot
Copy link

GH-20327 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2020
@Akarys42 @miss-islington
bpo-40439: Update broken link in lexical analysis docs (pythonGH-20184)
abcdd24 
Automerge-Triggered-By: @csabella
(cherry picked from commit af23f0d)

Co-authored-by: Matteo Bertucci <matteobertucci2004@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2020
@Akarys42 @miss-islington
bpo-40439: Update broken link in lexical analysis docs (pythonGH-20184)
588771e 
Automerge-Triggered-By: @csabella
(cherry picked from commit af23f0d)

Co-authored-by: Matteo Bertucci <matteobertucci2004@gmail.com>
@bedevere-bot
Copy link

GH-20328 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 23, 2020
@miss-islington @Akarys42
bpo-40439: Update broken link in lexical analysis docs (GH-20184)
0af9bef 
Automerge-Triggered-By: @csabella
(cherry picked from commit af23f0d)

Co-authored-by: Matteo Bertucci <matteobertucci2004@gmail.com>
miss-islington added a commit that referenced this pull request May 23, 2020
@miss-islington @Akarys42
bpo-40439: Update broken link in lexical analysis docs (GH-20184)
962c814 
Automerge-Triggered-By: @csabella
(cherry picked from commit af23f0d)

Co-authored-by: Matteo Bertucci <matteobertucci2004@gmail.com>
miss-islington added a commit that referenced this pull request May 23, 2020
@miss-islington @Akarys42
bpo-40439: Update broken link in lexical analysis docs (GH-20184)
dc32391 
Automerge-Triggered-By: @csabella
(cherry picked from commit af23f0d)

Co-authored-by: Matteo Bertucci <matteobertucci2004@gmail.com>
@Akarys42 Akarys42 deleted the bpo-40439 branch May 23, 2020 07:41
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@Akarys42 @arturoescaip
bpo-40439: Update broken link in lexical analysis docs (pythonGH-20184)
bd87d36 
Automerge-Triggered-By: @csabella
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabella csabella csabella approved these changes

@remilapeyre remilapeyre remilapeyre approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Akarys42 @the-knights-who-say-ni @miss-islington @bedevere-bot @csabella @remilapeyre