Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "move a dot outside double quotes" #20175

Merged
merged 2 commits into from
May 21, 2020
Merged

Revert "move a dot outside double quotes" #20175

merged 2 commits into from
May 21, 2020

Conversation

deronnax
Copy link
Contributor

As seen in #20007, contrary to what one would expect, in American English, dots go into quotes.
see https://www.thepunctuationguide.com/quotation-marks.html.

Reverts #20007

@deronnax deronnax requested review from abalkin and pganssle as code owners May 18, 2020 12:17
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 18, 2020
@pganssle
Copy link
Member

I think it's basically controversial how to do this, I like @zware's suggestion to reword the question so as to obviate the need to take a stance on this, I think:

Date and time objects may be categorized as "aware" or "naive" depending on whether or not they include timezone information.

both solves the problem and improves the reader's comprehension, so I call it a win-win.

pganssle
pganssle requested changes May 18, 2020
View reviewed changes
Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than revert, let's adopt @zware's suggestion.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@JulienPalard
Copy link
Member

I concour with @pganssle, using a workaround will save everybody the time to understand why the dot is here (allowing the brain to focus on what is said by the doc, which is good).

@deronnax
Copy link
Contributor Author

here you go

@deronnax deronnax requested a review from pganssle May 21, 2020 20:19
@pganssle pganssle merged commit 2e76820 into python:master May 21, 2020
@miss-islington
Copy link
Contributor

Thanks @deronnax for the PR, and @pganssle for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2020
@miss-islington
Reword aware/naive introduction sentence (pythonGH-20175)
8885bd4 
This is more informative and avoids the question of whether the period should go inside or outside the quotation marks.

See also pythonGH-20007.
(cherry picked from commit 2e76820)

Co-authored-by: Mathieu Dupuy <mathieu.dupuy@doctolib.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 21, 2020
@bedevere-bot
Copy link

GH-20298 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2020
@miss-islington
Reword aware/naive introduction sentence (pythonGH-20175)
ba75fdf 
This is more informative and avoids the question of whether the period should go inside or outside the quotation marks.

See also pythonGH-20007.
(cherry picked from commit 2e76820)

Co-authored-by: Mathieu Dupuy <mathieu.dupuy@doctolib.com>
@bedevere-bot
Copy link

GH-20299 is a backport of this pull request to the 3.8 branch.

@pganssle
Copy link
Member

Thanks @deronnax et al!

miss-islington added a commit that referenced this pull request May 22, 2020
@miss-islington
Reword aware/naive introduction sentence (GH-20175)
0714c48 
This is more informative and avoids the question of whether the period should go inside or outside the quotation marks.

See also GH-20007.
(cherry picked from commit 2e76820)

Co-authored-by: Mathieu Dupuy <mathieu.dupuy@doctolib.com>
miss-islington added a commit that referenced this pull request May 22, 2020
@miss-islington
Reword aware/naive introduction sentence (GH-20175)
c1d7768 
This is more informative and avoids the question of whether the period should go inside or outside the quotation marks.

See also GH-20007.
(cherry picked from commit 2e76820)

Co-authored-by: Mathieu Dupuy <mathieu.dupuy@doctolib.com>
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@arturoescaip
Reword aware/naive introduction sentence (pythonGH-20175)
1c83402 
This is more informative and avoids the question of whether the period should go inside or outside the quotation marks.

See also pythonGH-20007.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pganssle pganssle pganssle approved these changes

@zware zware zware approved these changes

@abalkin abalkin Awaiting requested review from abalkin

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@deronnax @pganssle @bedevere-bot @JulienPalard @miss-islington @zware @the-knights-who-say-ni