Skip to content

bpo-35890: Use RegQueryInfoKeyW and CryptAcquireContextW for consistency #19974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2020

Conversation

gongminmin
Copy link
Contributor

@gongminmin gongminmin commented May 7, 2020

Explicitly use the wide version RegQueryInfoKeyW and CryptAcquireContextW. It consistent with most Win32 API calls in the code base.

https://bugs.python.org/issue35890

@gongminmin gongminmin requested a review from tiran as a code owner May 8, 2020 07:16
@gongminmin gongminmin changed the title Use RegQueryInfoKeyW for consistency Use RegQueryInfoKeyW and CryptAcquireContextW for consistency May 8, 2020
@gongminmin gongminmin changed the title Use RegQueryInfoKeyW and CryptAcquireContextW for consistency bpo-35890: Use RegQueryInfoKeyW and CryptAcquireContextW for consistency May 16, 2020
@miss-islington
Copy link
Contributor

Thanks @gongminmin for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2020
…ythonGH-19974)

(cherry picked from commit 98e42d1)

Co-authored-by: Minmin Gong <gongminmin@msn.com>
@bedevere-bot
Copy link

GH-20189 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

Sorry, @gongminmin and @zooba, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 98e42d1f882b9b59f587d538c562dbc7d11c64c3 3.7

@miss-islington
Copy link
Contributor

Thanks @gongminmin for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @gongminmin and @zooba, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 98e42d1f882b9b59f587d538c562dbc7d11c64c3 3.7

@bedevere-bot
Copy link

GH-20190 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 18, 2020
…H-19974)

(cherry picked from commit 98e42d1)

Co-authored-by: Minmin Gong <gongminmin@msn.com>
zooba added a commit that referenced this pull request May 18, 2020
@gongminmin gongminmin deleted the RegQueryInfoKeyW branch May 20, 2020 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants