bpo-40493: fix function type comment parsing #19894
Conversation
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Thanks! How did you find this out so quickly?
Co-authored-by: Guido van Rossum <guido@python.org>
|
I've been trying to fix various mypy test failures on 3.9! |
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Awesome. Looking forward to your fixes. (Please CC me on any mypy PRs you submit.)
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Whoa, you need to regenerate parse.c (make regen-pegen).
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Right. Thanks for catching that! Github made it look deceptively easy there... I have made the requested changes; please review again |
|
Thanks for making the requested changes! @gvanrossum: please review the changes made to this pull request. |
|
And happy to cc you on mypy changes! :-) So far it's only the one (already merged): python/mypy#8743 (although I independently made the subscript AST fix of yours) |
|
@hauntsaninja: Status check is done, and it's a success ✅ . |
5 participants
The grammar for func_type_input rejected things like
(*t1) ->t2. This fixes that.https://bugs.python.org/issue40493
Automerge-Triggered-By: @gvanrossum