Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40455: Remove gcc10 warning about x_digits #19852

Merged
merged 3 commits into from
May 4, 2020
Merged

bpo-40455: Remove gcc10 warning about x_digits #19852

merged 3 commits into from
May 4, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented May 2, 2020 •
edited by bedevere-bot
Loading

@corona10 corona10 requested a review from mdickinson May 2, 2020 02:50
mdickinson
mdickinson suggested changes May 2, 2020
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach looks good to me, but there's a logic error to fix. I'm a little bit disturbed that we didn't get more test failures here.

Objects/longobject.c Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@corona10
Copy link
Member Author

corona10 commented May 2, 2020

Thank you for the review and for catching the missed thing :)
I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@mdickinson: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from mdickinson May 2, 2020 13:29
mdickinson
mdickinson approved these changes May 2, 2020
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@corona10
Copy link
Member Author

corona10 commented May 2, 2020 •
edited
Loading

@vstinner Since I am still in the mentoring period, I will merge this after your confirm :)

@corona10 corona10 self-assigned this May 2, 2020
shihai1991
shihai1991 approved these changes May 3, 2020
View reviewed changes
Copy link
Member

@shihai1991 shihai1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vstinner
vstinner approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

My main worry is that this change will initialize twice a few digits and so it would make the code less efficient. But @mdickinson approved the change, so I'm fine with it :-)

The change is correct. Initializing digits to zero cannot be wrong :-)

@corona10 corona10 merged commit b88cd58 into python:master May 4, 2020
@bedevere-bot
Copy link

@corona10: Please replace # with GH- in the commit message next time. Thanks!

@corona10 corona10 deleted the bpo-40455 branch May 4, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@mdickinson mdickinson mdickinson approved these changes

@shihai1991 shihai1991 shihai1991 approved these changes

Assignees

@corona10 corona10

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@corona10 @bedevere-bot @vstinner @mdickinson @shihai1991 @the-knights-who-say-ni