Simplify choice()'s interaction with the private _randbelow() method#19831
Merged
rhettinger merged 4 commits intopython:masterfrom May 1, 2020
Merged
Simplify choice()'s interaction with the private _randbelow() method#19831rhettinger merged 4 commits intopython:masterfrom
rhettinger merged 4 commits intopython:masterfrom
Conversation
serhiy-storchaka
approved these changes
May 1, 2020
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Besides few typos LGTM.
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
approved these changes
May 1, 2020
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. All other uses of _randbelow() check the argument for zero before the call.
On other hand, I would expect choice([]) raising a ValueError. IndexError is a legacy, a detail of the past implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
https://github.com/python/cpython/blob/2.7/Lib/random.py#L275just let the indexing raise an IndexError. An intermediate trip through a ValueError isn't necessary.