Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40334: Support type comments #19780

Merged
merged 12 commits into from
Apr 30, 2020
Prev Previous commit
Next Next commit
Fix bug in add_type_comment()
  • Loading branch information
gvanrossum committed Apr 29, 2020
commit 86d9f6957f462837bc77d925099cdcf5f2ee82da
2 changes: 1 addition & 1 deletion Parser/pegen/pegen.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ _PyPegen_add_type_comment(Parser *p, arg_ty a, char *tc)
if (tc == NULL) {
return a;
}
PyObject *tco = _PyPegen_new_type_comment(p, tc);
PyObject *tco = NEW_TYPE_COMMENT(tc);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't NEW_TYPE_COMMENT expect tc to be a Token *, i.e. that tc->bytes is a bytes object? I feel that NEW_TYPE_COMMENT would better be off as an inline function.

if (tco == NULL) {
return NULL;
}
Expand Down