-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-40334: Support type comments #19780
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e17bb92
First steps towards supporting type comments
gvanrossum 2e4126c
Support func_type_input in new parser
gvanrossum 7b446fb
Support '# type: ignore <tag>'
gvanrossum ed95a14
Support per-argument type comments ('long form')
gvanrossum acb69b3
Fix segfault in long-form argument type comments
gvanrossum 1e8f7fd
Fix failing test_ast by refactoring param rules
gvanrossum da253f3
Merge remote-tracking branch 'origin/master' into type-comments
gvanrossum 86d9f69
Fix bug in add_type_comment()
gvanrossum c8a2888
Suggestions from code review
gvanrossum fd2794b
Refactoring some things in response to review
gvanrossum d081578
More thorough error checks in NEW_TYPE_COMMENT
gvanrossum fecd8e8
Add CHECK() around _PyPegen_seq_append_to_end() call
gvanrossum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix bug in add_type_comment()
- Loading branch information
commit 86d9f6957f462837bc77d925099cdcf5f2ee82da
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't
NEW_TYPE_COMMENT
expecttc
to be aToken *
, i.e. thattc->bytes
is a bytes object? I feel thatNEW_TYPE_COMMENT
would better be off as an inline function.