Skip to content

bpo-34037: Add Python API whatsnew for loop.shutdown_default_executor() #19634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2020
Merged

bpo-34037: Add Python API whatsnew for loop.shutdown_default_executor() #19634

merged 2 commits into from
Apr 21, 2020

Conversation

aeros
Copy link
Contributor

@aeros aeros commented Apr 21, 2020 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Apr 21, 2020
vstinner
vstinner approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart the typo ;-)

@aeros @vstinner
Fix typo
6539f80 
Co-Authored-By: Victor Stinner <vstinner@python.org>
@aeros
Copy link
Contributor Author

aeros commented Apr 21, 2020 •
edited
Loading

Thanks for the review @vstinner. I'll merge it after the CI finishes.

@aeros aeros merged commit 9c82ea7 into python:master Apr 21, 2020
@bedevere-bot
Copy link

@aeros: Please replace # with GH- in the commit message next time. Thanks!

@aeros
Copy link
Contributor Author

aeros commented Apr 21, 2020

I wanted to try merging via the GitHub "Squash and Merge" instead of with automerge this time. I told myself just a minute ago "remember to change it to GH-", and I still completely forgot, haha.

But, I suppose that's somewhat inevitable as a new core dev, seeing as experienced core devs still manage to forget this step on occasion. :-)

@aeros aeros deleted the bpo34037-shutdown_default_executor-api-whatsnew branch April 21, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aeros @bedevere-bot @vstinner @the-knights-who-say-ni