bpo-30631: Silence MSVC warnings (win32) #1963

segevfiner · 2017-06-05T23:58:48Z

I silenced the specific warnings we are getting and not all warnings from those external libraries that build with warnings.

Those are hand rolled msbuild files and I'm no msbuild expert. So I hope I did it correctly.

segevfiner · 2017-06-11T18:26:27Z

cc @zooba @zware

zware · 2017-06-11T19:03:48Z

Could you add a bpo issue number to the title? I think there may be an existing issue for this; otherwise please open one.

segevfiner · 2017-06-11T22:15:38Z

@zware I only manged to find bpo-9566 about some specific warnings in 64-bit, but this PR is about other warnings in 32-bit. I opened a separate issue about the warnings I silenced here.

zware

This looks pretty good, but I have a couple of questions.

zware · 2017-06-11T22:36:54Z

PCbuild/pcbuild.sln

@@ -9,6 +9,9 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
 	EndProjectSection
 EndProject
 Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "python", "python.vcxproj", "{B11D750F-CD1F-4A96-85CE-E69A5C5259F9}"
+	ProjectSection(ProjectDependencies) = postProject
+		{0E9791DB-593A-465F-98BC-681011311618} = {0E9791DB-593A-465F-98BC-681011311618}
+	EndProjectSection


What is this change?

This is a project dependency: python -> _ctypes. This is to avoid ValidateUcrtbase failing since it uses _ctypes and runs before _ctypes is built.

Added by: Build Dependencies ->Project Dependencies....

zware · 2017-06-11T22:41:19Z

PCbuild/_socket.vcxproj

@@ -60,6 +60,9 @@
    <_ProjectFileVersion>10.0.30319.1</_ProjectFileVersion>
  </PropertyGroup>
  <ItemDefinitionGroup>
+    <ClCompile>
+      <PreprocessorDefinitions>_WINSOCK_DEPRECATED_NO_WARNINGS;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+    </ClCompile>


This is the only change that I have a bit of a problem with: _socket is an internal module, so we should fix warnings rather than papering over them, if possible. How much effort would it take to avoid the deprecated bits?

This is the list of warnings in "socketmodule.c":

..\Modules\socketmodule.c(1067): warning C4996: 'inet_addr': Use inet_pton() or InetPton() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [C:\projects\cpython\PCbuild\_socket.vcxproj] C:\Program Files (x86)\Windows Kits\8.1\Include\um\winsock2.h(1850): note: see declaration of 'inet_addr' ..\Modules\socketmodule.c(4408): warning C4996: 'WSADuplicateSocketA': Use WSADuplicateSocketW() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [C:\projects\cpython\PCbuild\_socket.vcxproj] C:\Program Files (x86)\Windows Kits\8.1\Include\um\winsock2.h(2872): note: see declaration of 'WSADuplicateSocketA' ..\Modules\socketmodule.c(4648): warning C4996: 'WSASocketA': Use WSASocketW() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [C:\projects\cpython\PCbuild\_socket.vcxproj] C:\Program Files (x86)\Windows Kits\8.1\Include\um\winsock2.h(3457): note: see declaration of 'WSASocketA' ..\Modules\socketmodule.c(4681): warning C4996: 'WSASocketA': Use WSASocketW() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [C:\projects\cpython\PCbuild\_socket.vcxproj] C:\Program Files (x86)\Windows Kits\8.1\Include\um\winsock2.h(3457): note: see declaration of 'WSASocketA' ..\Modules\socketmodule.c(5119): warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [C:\projects\cpython\PCbuild\_socket.vcxproj] C:\Program Files (x86)\Windows Kits\8.1\Include\um\winsock2.h(2238): note: see declaration of 'gethostbyname' ..\Modules\socketmodule.c(5217): warning C4996: 'gethostbyaddr': Use getnameinfo() or GetNameInfoW() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [C:\projects\cpython\PCbuild\_socket.vcxproj] C:\Program Files (x86)\Windows Kits\8.1\Include\um\winsock2.h(2216): note: see declaration of 'gethostbyaddr' ..\Modules\socketmodule.c(5347): warning C4996: 'WSADuplicateSocketA': Use WSADuplicateSocketW() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [C:\projects\cpython\PCbuild\_socket.vcxproj] C:\Program Files (x86)\Windows Kits\8.1\Include\um\winsock2.h(2872): note: see declaration of 'WSADuplicateSocketA' ..\Modules\socketmodule.c(5350): warning C4996: 'WSASocketA': Use WSASocketW() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [C:\projects\cpython\PCbuild\_socket.vcxproj] C:\Program Files (x86)\Windows Kits\8.1\Include\um\winsock2.h(3457): note: see declaration of 'WSASocketA' ..\Modules\socketmodule.c(5669): warning C4996: 'inet_addr': Use inet_pton() or InetPton() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [C:\projects\cpython\PCbuild\_socket.vcxproj] C:\Program Files (x86)\Windows Kits\8.1\Include\um\winsock2.h(1850): note: see declaration of 'inet_addr' ..\Modules\socketmodule.c(5712): warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [C:\projects\cpython\PCbuild\_socket.vcxproj] C:\Program Files (x86)\Windows Kits\8.1\Include\um\winsock2.h(1868): note: see declaration of 'inet_ntoa' ..\Modules\socketmodule.c(5786): warning C4996: 'WSAStringToAddressA': Use WSAStringToAddressW() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [C:\projects\cpython\PCbuild\_socket.vcxproj] C:\Program Files (x86)\Windows Kits\8.1\Include\um\winsock2.h(3623): note: see declaration of 'WSAStringToAddressA' ..\Modules\socketmodule.c(5925): warning C4996: 'WSAAddressToStringA': Use WSAAddressToStringW() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [C:\projects\cpython\PCbuild\_socket.vcxproj] C:\Program Files (x86)\Windows Kits\8.1\Include\um\winsock2.h(3556): note: see declaration of 'WSAAddressToStringA'

Calling inet_addr, inet_ntoa, gethostbyname and gethostbyaddr is probably unavoidable. The rest are due to building with ANSI charset and getting the WinAPI defines set to call the ANSI functions rather than the Unicode ones. It is set to build with ANSI explicitly in the _socket.vcxproj (<CharacterSet>NotSet</CharacterSet>). I don't know the reasons for this, but there might be other functions in "socketmodule.c" affected by the charset defines. Changing this will likely also break the ability to pass sockets between Python versions before/after the change on Windows using share/fromshare.

Yeah, this is a tough one to fix, but it eventually needs to be fixed.

I deliberately left the warnings there as motivation - we should not suppress them.

zooba · 2017-06-12T19:20:22Z

Apart from the socket module warnings, this looks fine to me. I don't want those to be suppressed - I want the implementation changed to avoid those functions.

zware · 2017-06-16T03:12:20Z

Thanks, @segevfiner!

segevfiner added 6 commits June 6, 2017 01:55

Silence liblzma warnings in MSVC

bd970bc

Silence socketmodule.c warnings in MSVC

a678c74

Silence OpenSSL warnings in MSVC

3bd1035

Fix tix warnings in MSVC

3575d27

Fix validateUcrtbase failing due to missing _ctypes

e61f333

Undo random whitespace differences due to editor

0330a2d

the-knights-who-say-ni added the CLA signed label Jun 5, 2017

Merge remote-tracking branch 'upstream/master' into fix-msvc-warnings

f02f5c2

segevfiner changed the title ~~Silence MSVC warnings (win32)~~ bpo-30631: Silence MSVC warnings (win32) Jun 11, 2017

zware reviewed Jun 11, 2017

View reviewed changes

bpo-30631: Removed _WINSOCK_DEPRECATED_NO_WARNINGS from _socket.vcxproj

220bc5f

zware approved these changes Jun 13, 2017

View reviewed changes

zware merged commit c931885 into python:master Jun 16, 2017

segevfiner deleted the fix-msvc-warnings branch June 16, 2017 10:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-30631: Silence MSVC warnings (win32) #1963

bpo-30631: Silence MSVC warnings (win32) #1963

segevfiner commented Jun 5, 2017

segevfiner commented Jun 11, 2017

zware commented Jun 11, 2017

segevfiner commented Jun 11, 2017

zware left a comment

zware Jun 11, 2017

segevfiner Jun 12, 2017

zooba Jun 12, 2017

zware Jun 11, 2017

segevfiner Jun 12, 2017

zooba Jun 12, 2017

zooba commented Jun 12, 2017

zware commented Jun 16, 2017

bpo-30631: Silence MSVC warnings (win32) #1963

bpo-30631: Silence MSVC warnings (win32) #1963

Conversation

segevfiner commented Jun 5, 2017

segevfiner commented Jun 11, 2017

zware commented Jun 11, 2017

segevfiner commented Jun 11, 2017

zware left a comment

Choose a reason for hiding this comment

zware Jun 11, 2017

Choose a reason for hiding this comment

segevfiner Jun 12, 2017

Choose a reason for hiding this comment

zooba Jun 12, 2017

Choose a reason for hiding this comment

zware Jun 11, 2017

Choose a reason for hiding this comment

segevfiner Jun 12, 2017

Choose a reason for hiding this comment

zooba Jun 12, 2017

Choose a reason for hiding this comment

zooba commented Jun 12, 2017

zware commented Jun 16, 2017