Skip to content

Fix typo in Lib/traceback.py#19605

Merged
miss-islington merged 1 commit intopython:masterfrom
wudenggang:typo-fix
Apr 20, 2020
Merged

Fix typo in Lib/traceback.py#19605
miss-islington merged 1 commit intopython:masterfrom
wudenggang:typo-fix

Conversation

@wudenggang
Copy link
Contributor

@wudenggang wudenggang commented Apr 19, 2020 •
edited by miss-islington
Loading

Typo fix: "emites" -> "emit".

Automerge-Triggered-By: @aeros

@wudenggang
typo fix : emit
8b5c23e 
typo fix : emit
aeros
aeros approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@aeros aeros left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @wudenggang; it looks fine to me.

Also as an FYI, the "skip issue" and "skip news" parts are for a triager or core dev to add to the PR as labels, that shouldn't be included in the title or description. I'll adjust it accordingly prior to merging (since automerge uses it for the commit description).

@aeros aeros changed the title typo fix : emit, skip issue Fix typo in Lib/tracepack.py Apr 20, 2020
@miss-islington miss-islington merged commit df8913f into python:master Apr 20, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Apr 20, 2020

Thanks @wudenggang for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 20, 2020
@wudenggang @miss-islington
Fix typo in Lib/tracepack.py (pythonGH-19605)
0d109c0 
Typo fix: "emites" -> "emit".
(cherry picked from commit df8913f)

Co-authored-by: Galden <wudenggang0@163.com>
@bedevere-bot
Copy link

bedevere-bot commented Apr 20, 2020

GH-19613 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

bedevere-bot commented Apr 20, 2020

GH-19614 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 20, 2020
@wudenggang @miss-islington
Fix typo in Lib/tracepack.py (pythonGH-19605)
4d04247 
Typo fix: "emites" -> "emit".
(cherry picked from commit df8913f)

Co-authored-by: Galden <wudenggang0@163.com>
@aeros
Copy link
Contributor

aeros commented Apr 20, 2020 •
edited
Loading

Oops, looks like I made a minor typo in the commit title. I don't think it will be an issue in this case though, as it's clear what it was intended to be. I fixed it in the backport PR titles.

@aeros aeros changed the title Fix typo in Lib/tracepack.py Fix typo in Lib/traceback.py Apr 20, 2020
miss-islington added a commit that referenced this pull request Apr 20, 2020
@miss-islington @wudenggang
Fix typo in Lib/tracepack.py (GH-19605)
984a567 
Typo fix: "emites" -> "emit".
(cherry picked from commit df8913f)

Co-authored-by: Galden <wudenggang0@163.com>
miss-islington added a commit that referenced this pull request Apr 20, 2020
@miss-islington @wudenggang
Fix typo in Lib/tracepack.py (GH-19605)
d0d4e33 
Typo fix: "emites" -> "emit".
(cherry picked from commit df8913f)

Co-authored-by: Galden <wudenggang0@163.com>
@wudenggang wudenggang deleted the typo-fix branch April 20, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@remilapeyre remilapeyre remilapeyre approved these changes

@aeros aeros aeros approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wudenggang @miss-islington @bedevere-bot @aeros @remilapeyre @the-knights-who-say-ni