Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32494: Add gdbm.count() #19569

Closed
wants to merge 1 commit into from
Closed

bpo-32494: Add gdbm.count() #19569

wants to merge 1 commit into from

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Apr 17, 2020 •
edited by bedevere-bot
Loading

gdbm_count() was added in GDBM 1.11.

https://bugs.python.org/issue32494

@ZackerySpytz
bpo-32494: Add gdbm.count()
c608ef0 
gdbm_count() was added in GDBM 1.11.
pitrou
pitrou requested changes Apr 18, 2020
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This looks mostly good, just one comment.

Modules/_gdbmmodule.c
{
gdbm_count_t count;
check_dbmobject_open(self);
if (gdbm_count(self->di_dbm, &count) == -1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to set errno = 0 before this.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

corona10
corona10 reviewed Apr 18, 2020
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZackerySpytz @pitrou

Can we just replace the logic of dbm_length to use gdbm_count when the version is available?

cpython/Modules/_gdbmmodule.c

Line 98 in 1b55b65

dbm_length(dbmobject *dp)

if possible, we don't have to export a new method.

@pitrou
Copy link
Member

pitrou commented May 1, 2020

Superseded by PR #19814. Closing.

@pitrou pitrou closed this May 1, 2020
@sam-s sam-s mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 left review comments

@pitrou pitrou pitrou requested changes

Assignees
No one assigned
Labels
awaiting changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ZackerySpytz @bedevere-bot @pitrou @corona10 @the-knights-who-say-ni