bpo-39285: Clarify example for PurePath.match#19458
Merged
miss-islington merged 1 commit intopython:masterfrom Apr 19, 2020
Merged
bpo-39285: Clarify example for PurePath.match#19458miss-islington merged 1 commit intopython:masterfrom
miss-islington merged 1 commit intopython:masterfrom
Conversation
Member
|
I don't understand this PR. The point of this snippet in the documentation is to show that case-sensitivity follows platform defaults. >>> PurePosixPath('b.py').match('*.PY')
False
>>> PureWindowsPath('b.py').match('*.PY')
True |
Member
|
cc @barneygale |
Contributor
|
Sounds like a wording problem. This sentence:
Can be taken to mean that
I agree that an additional example involving |
Fixes Issue39285 Provide additional example and update wording to remove ambiguity around the match functionlatiy.
Contributor
Author
|
Thanks! I've updated the example and wording to incorporate the feedback. |
Contributor
|
Thanks @timlo for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 19, 2020
Fixes Issue39285 The example incorrectly returned True for match. Furthermore the example is ambiguous in its usage of PureWindowsPath. Windows is case-insensitve, however the underlying match functionality utilizes fnmatch.fnmatchcase. Automerge-Triggered-By: @pitrou (cherry picked from commit c12375a) Co-authored-by: Tim Lo <timlo@users.noreply.github.com>
|
GH-19597 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 19, 2020
Fixes Issue39285 The example incorrectly returned True for match. Furthermore the example is ambiguous in its usage of PureWindowsPath. Windows is case-insensitve, however the underlying match functionality utilizes fnmatch.fnmatchcase. Automerge-Triggered-By: @pitrou (cherry picked from commit c12375a) Co-authored-by: Tim Lo <timlo@users.noreply.github.com>
|
GH-19598 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Apr 19, 2020
Fixes Issue39285 The example incorrectly returned True for match. Furthermore the example is ambiguous in its usage of PureWindowsPath. Windows is case-insensitve, however the underlying match functionality utilizes fnmatch.fnmatchcase. Automerge-Triggered-By: @pitrou (cherry picked from commit c12375a) Co-authored-by: Tim Lo <timlo@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Apr 19, 2020
Fixes Issue39285 The example incorrectly returned True for match. Furthermore the example is ambiguous in its usage of PureWindowsPath. Windows is case-insensitve, however the underlying match functionality utilizes fnmatch.fnmatchcase. Automerge-Triggered-By: @pitrou (cherry picked from commit c12375a) Co-authored-by: Tim Lo <timlo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue39285
The example incorrectly returned True for match.
Furthermore the example is ambiguous in its usage of PureWindowsPath.
Windows is case-insensitve, however the underlying match functionality
utilizes fnmatch.fnmatchcase.
https://bugs.python.org/issue39285
https://bugs.python.org/issue39285
Automerge-Triggered-By: @pitrou