Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-19468: delete unnecessary instance check in importlib.reload() #19424

Merged
merged 3 commits into from
Jun 5, 2020
Merged

bpo-19468: delete unnecessary instance check in importlib.reload() #19424

merged 3 commits into from
Jun 5, 2020

Conversation

furkanonder
Copy link
Contributor

@furkanonder furkanonder commented Apr 7, 2020 •
edited by miss-islington
Loading

@furkanonder furkanonder changed the title bpo:19468 delete unnecessary modul control statement bpo-19468: delete unnecessary modul control statement Apr 7, 2020
eamanu
eamanu approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eamanu
Copy link
Contributor

eamanu commented Apr 8, 2020

IMO news could be skipped.

ericsnowcurrently
ericsnowcurrently approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I expect there could possibly be some deep corner cases (via _bootstrap._find_spec() and _bootstrap._exec() that would change behavior here, but find it highly unlikely that, if such cases even exist, anyone relies on them. 😄

@furkanonder
Copy link
Contributor Author

@brettcannon

@brettcannon brettcannon changed the title bpo-19468: delete unnecessary modul control statement bpo-19468: delete unnecessary instance check in importlib.reload() May 28, 2020
@brettcannon
Copy link
Member

LGTM, although I think a news entry is still appropriate.

brettcannon
brettcannon requested changes May 28, 2020
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a news entry as it changes the semantics of the function.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@furkanonder furkanonder requested a review from brettcannon May 30, 2020 23:19
@brettcannon
Copy link
Member

@furkanonder please read the instructions from the bot on how to signal you're ready for another review.

@furkanonder
Copy link
Contributor Author

@furkanonder please read the instructions from the bot on how to signal you're ready for another review.

Sorry, I missed it. I have made the requested changes; please review again :)

@bedevere-bot
Copy link

Thanks for making the requested changes!

@brettcannon, @ericsnowcurrently: please review the changes made to this pull request.

@brettcannon brettcannon closed this Jun 5, 2020
@brettcannon brettcannon reopened this Jun 5, 2020
@miss-islington
Copy link
Contributor

@furkanonder: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit fef1fae into python:master Jun 5, 2020
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@furkanonder @arun-mani-j
bpo-19468: delete unnecessary instance check in importlib.reload() (p…
dcc0fb8 
…ythonGH-19424)

Automerge-Triggered-By: @brettcannon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@eamanu eamanu eamanu approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@furkanonder @eamanu @brettcannon @bedevere-bot @miss-islington @ericsnowcurrently @the-knights-who-say-ni