bpo-19468: delete unnecessary instance check in importlib.reload()#19424
Conversation
furkanonder
changed the title
|
IMO news could be skipped. |
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
There was a problem hiding this comment.
LGTM
I expect there could possibly be some deep corner cases (via _bootstrap._find_spec() and _bootstrap._exec() that would change behavior here, but find it highly unlikely that, if such cases even exist, anyone relies on them. 😄
brettcannon
changed the title
|
LGTM, although I think a news entry is still appropriate. |
brettcannon
left a comment
brettcannon
left a comment
There was a problem hiding this comment.
Needs a news entry as it changes the semantics of the function.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
@furkanonder please read the instructions from the bot on how to signal you're ready for another review. |
Sorry, I missed it. I have made the requested changes; please review again :) |
|
Thanks for making the requested changes! @brettcannon, @ericsnowcurrently: please review the changes made to this pull request. |
|
@furkanonder: Status check is done, and it's a success ✅ . |
7 participants
https://bugs.python.org/issue19468
Automerge-Triggered-By: @brettcannon