-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-1635741: Port _lzma module to multiphase initialization #19382
Conversation
I ran the several leak test also for subinterp. class SubinterpThreadingTests(unittest.TestCase):
def test_lzma_subinterp(self):
code = textwrap.dedent(r"""
import os
from lzma import LZMACompressor, LZMADecompressor, LZMAError
lzc = LZMACompressor()
lzd = LZMADecompressor()
def noop(*args):
pass
os.register_at_fork(after_in_child=noop)
""")
ret = support.run_in_subinterp(code) |
@shihai1991 Can you please take a look? |
7558ffb
to
525190c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, LGTM.
@vstinner Please take a look :) |
with patch (https://bugs.python.org/issue40149#msg365560)
|
498affa
to
c556f77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just two minor coding style remarks.
https://bugs.python.org/issue1635741